Skip to content

Report a problem steps aside while the View or Share panel is open (Issue #1861) - #1158

Merged
grunion-ai merged 1 commit into
mainfrom
claude/fab-clear-panels-1861-1795200214
Nov 20, 2026
Merged

grunion-ai merged 1 commit into
mainfrom
claude/fab-clear-panels-1861-1795200214

Conversation

@grunion-ai

Copy link
Copy Markdown
Owner

Tracker: Issue #1861 (https://weave.grunion.ai/w/weave/e/5e34760b-8713-4484-ae2f-f8ab47ae1948), held by the edge collision ratchet from Feature #388 (#1157).

What changed

  • public/style.css: the floating .bug-fab hides while #view-pane or #share-pane is open, added to the rule that already hides it over the file viewer and file panel (Issue #1193). Report a problem stays in Your menu.
  • test/edge-collision-baseline.json: the six view-panel "Clear all + Report a problem" entries for #1861 are gone, on darwin and linux.
  • test/bug-fab-panels-browser.test.mjs (new): at 1440 and 1024 px the bug button stays clear of the open View panel, the bottom right corner of Clear all answers to Clear all, and the button returns to its corner when the panel closes; the same for the Share panel at 1440.
  • changelog.d/bug-button-panels-1861.md.

Why this shape

Feature #388 offered two shapes: shift the button by the open panel's width, or a stacking layer below the panels.

  • Shift, tried first: the button moved onto the right end of + New record in the table footer beside the Share panel at all six desktop widths (the sweep reported 6 new share-panel collisions, the defect Issue #1875 tracks).
  • Layer below the panels: the panels are unpositioned flex items, so they would need a z-index above 1150, which puts them over the modal backdrops; the hidden button also stays in the tab order.
  • Hiding matches the existing #1193 rule, and the visible result equals the layer option.

Verification

  • Before the fix, test/bug-fab-panels-browser.test.mjs failed all three cases (button at [1396, 856, 1422, 882] inside the View panel at [1112, 8, 1432, 892]).
  • Before dropping the baseline entries, test/edge-collision-browser.test.mjs failed with six gone: lines for #1861 and nothing new.
  • After: green locally for edge-collision core and browser, bug-fab-panels, bug-panel, bug-fab-phone, outside-dismiss, pane-scroll-shell, phone-no-zoom, ui-contract, changelog-fragments, no-inline-comments.
  • Both themes: the change is display: none on one control, so neither theme paints anything new.

…s open (Issue #1861)

The fixed bug button (right 18 px, bottom 18 px, z-index 1150) sat on the
last 24 x 24 px of Clear all at the foot of the View panel at every desktop
width. It now hides while #view-pane or #share-pane is open, the same rule
that already hides it over the file viewer and the file panel (Issue
#1193). Report a problem stays reachable from Your menu.

Shifting it by the open panel's width was tried first: it moved the button
onto the right end of + New record in the table footer beside the Share
panel, the defect Issue #1875 tracks, at six widths. A stacking layer below
the panels needs positioned panes above the modal layers, and leaves an
invisible button in the tab order; hiding it has the same visible result.

The edge collision baseline drops its six #1861 entries on both platforms.

Change-Id: I736bf37b8ca6d0b16d3e5b78aff8540277e6fa51
@grunion-ai
grunion-ai enabled auto-merge (squash) November 20, 2026 18:58
@grunion-ai
grunion-ai merged commit 877b418 into main Nov 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant