Repository navigation
Report a problem steps aside while the View or Share panel is open (Issue #1861) - #1158
Merged
Merged
Conversation
…s open (Issue #1861) The fixed bug button (right 18 px, bottom 18 px, z-index 1150) sat on the last 24 x 24 px of Clear all at the foot of the View panel at every desktop width. It now hides while #view-pane or #share-pane is open, the same rule that already hides it over the file viewer and the file panel (Issue #1193). Report a problem stays reachable from Your menu. Shifting it by the open panel's width was tried first: it moved the button onto the right end of + New record in the table footer beside the Share panel, the defect Issue #1875 tracks, at six widths. A stacking layer below the panels needs positioned panes above the modal layers, and leaves an invisible button in the tab order; hiding it has the same visible result. The edge collision baseline drops its six #1861 entries on both platforms. Change-Id: I736bf37b8ca6d0b16d3e5b78aff8540277e6fa51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracker: Issue #1861 (https://weave.grunion.ai/w/weave/e/5e34760b-8713-4484-ae2f-f8ab47ae1948), held by the edge collision ratchet from Feature #388 (#1157).
What changed
public/style.css: the floating.bug-fabhides while#view-paneor#share-paneis open, added to the rule that already hides it over the file viewer and file panel (Issue #1193). Report a problem stays in Your menu.test/edge-collision-baseline.json: the sixview-panel"Clear all + Report a problem" entries for #1861 are gone, on darwin and linux.test/bug-fab-panels-browser.test.mjs(new): at 1440 and 1024 px the bug button stays clear of the open View panel, the bottom right corner of Clear all answers to Clear all, and the button returns to its corner when the panel closes; the same for the Share panel at 1440.changelog.d/bug-button-panels-1861.md.Why this shape
Feature #388 offered two shapes: shift the button by the open panel's width, or a stacking layer below the panels.
share-panelcollisions, the defect Issue #1875 tracks).Verification
test/bug-fab-panels-browser.test.mjsfailed all three cases (button at [1396, 856, 1422, 882] inside the View panel at [1112, 8, 1432, 892]).test/edge-collision-browser.test.mjsfailed with sixgone:lines for #1861 and nothing new.display: noneon one control, so neither theme paints anything new.