Repository navigation
Two-row header with a New button on table and board views (Feature #384) - #1156
Merged
Merged
Conversation
…ure #384) Row 1 holds the breadcrumb, Copy permalink and the pane controls weave already had (Expand and Close in the dock, Close on a record page). Row 2 holds what the page is and what you can do to it: the table icon, title and description toggle with Search, View, Share, the table menu and a New button named for the table's record; on a record, the table icon and #id with Show or hide fields, Share and the record menu. - A record's breadcrumb ends at the table and the #id, so the name shows once, as the title (Issue #1862). - The View button carries its active-filter count in row 2 (Issue #1863). - Title, description toggle and toolbar share one centred line, and the band above the grid closes to the header's 16 px padding (Issue #1867). - Table titles drop to 16 px (--fs-doc) and record titles to 20 px (--fs-h1); .title-edit weight moves to 600 for both. - Supersedes Feature #377 rule 1; the one-row tests now assert two rows. ponytail: - public/app.js fitHeadBar: row 2 condenses by one overflow measure on resize only; a content change such as a new filter badge waits for the next resize. Upgrade path: also observe the toolbar's children. Change-Id: I7059a1804fbf494bc3d2694bdc778c1f71c4abfd
grunion-ai
enabled auto-merge (squash)
November 20, 2026 18:24
added 3 commits
November 20, 2026 14:17
) - The record page hides its collapse arrows again: the rule now outranks the bar-button sizing rule. - The record title textarea joins the coarse-pointer touch floor, so the 20 px title keeps a 44 px target. - The description toggle's touch box no longer overlaps the title. - On a phone the filter popover may use the screen's height, since the tools sheet now opens one row lower. - Suites that read the record crumb's name read its #id (Issue #1862). Change-Id: I1ccddc64c7c43d9536e0d0a1ba64e702aed8572f
Change-Id: Id4750eea582de793b4b2105a569cfa543a4b5e67
#384) - Row 2 measures the title at its text width, so a table with no description condenses before its toolbar runs into the title. - A condensed row 2 folds New to its + icon and drops the table icon. - The edge-collision helpers open the phone tools sheet from row 2. - The phone header pin stops pinning crumb folding, which follows each platform's fonts. No-changelog: changelog.d/two-row-header-384.md on this branch covers Feature #384 Change-Id: Ieb128c494139d9539689e43a6aae24ce84e7b56e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature #384: https://weave.grunion.ai/w/weave/e/ac17eda3-9b7e-4d6e-8cf5-aeba9a950c0d
Fixes Issues #1862, #1863 and #1867. Supersedes rule 1 of Feature #377.
What changed
#id, then Show or hide fields, Share and the record menu moved down unchanged.#id; the name shows once, as the title (Issue #1862).--fs-doc) weight 600, record title 20 px (--fs-h1), crumbs stay 13 px. No new type step; the eight-step scale holds.crumb-row-tight.table-views.mdandmaking-a-workspace-your-own.mddescribe the two rows and the New button.Tests
test/record-header-one-row-browser.test.mjsrewritten: row 1 is one line with no clipped crumb from 320 to 1920 px on the record page and the table, the toolbar lives in row 2, no header control overlaps another, no sideways page scroll; plus the dock, row membership, the once-only record name, the font sizes, the centred line and the View count.test/header-new-record-browser.test.mjs: the New button is on table and board views, last in row 2, and creates a record in that table.test/lib/header-bar.mjs; selector moves (.crumb-row .dots-btnto.head-bar .dots-btn) in the rest.supervisor.test.mjscases that time out under machine load ("the worker never listened") and pass on CI.Screenshots
Light and dark at 1440 x 900 are in the Feature #384 row after landing.