Isobrowser's filesystem #2013
Isobrowser's filesystem #2013
CodeScene PR Check
Quality Gate Failed
Gates Failed
Enforce critical code health rules
(2 files with Bumpy Road Ahead, Deep, Nested Complexity)
Enforce advisory code health rules
(2 files with Overall Function Size, Complex Method, Complex Conditional, Overall Code Complexity)
Gates Passed
2 Quality Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| isobrowser.cc | 2 critical rules | 8.77 → 3.07 | Suppress |
| iso9660-reader.cc | 1 critical rule | 8.96 → 8.82 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| isobrowser.cc | 4 advisory rules | 8.77 → 3.07 | Suppress |
| luaiso.cc | 2 advisory rules | 10.00 → 8.92 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Overall Code Complexity isobrowser.cc
- Complex Method isobrowser.cc: PCSX::Widgets::IsoBrowser::draw
- Bumpy Road Ahead isobrowser.cc: PCSX::Widgets::IsoBrowser::draw
- Complex Method isobrowser.cc: PCSX::Widgets::IsoBrowser::drawFilesystemFlat
- Complex Method isobrowser.cc: PCSX::Widgets::IsoBrowser::scanAllGaps
- Deep, Nested Complexity isobrowser.cc: PCSX::Widgets::IsoBrowser::draw
- Overall Function Size isobrowser.cc
- Bumpy Road Ahead isobrowser.cc: PCSX::Widgets::IsoBrowser::scanAllGaps
- Deep, Nested Complexity isobrowser.cc: PCSX::Widgets::IsoBrowser::scanAllGaps
- Bumpy Road Ahead isobrowser.cc: PCSX::Widgets::IsoBrowser::drawFilesystemFlat
- Deep, Nested Complexity isobrowser.cc: PCSX::Widgets::IsoBrowser::drawFilesystemTree
- Deep, Nested Complexity isobrowser.cc: PCSX::Widgets::IsoBrowser::drawFilesystemFlat
- Complex Method isobrowser.cc: PCSX::Widgets::IsoBrowser::drawFilesystemTree
- Bumpy Road Ahead isobrowser.cc: PCSX::Widgets::IsoBrowser::drawFilesystemTree
- Complex Conditional luaiso.cc: stripSelfParent
- Complex Conditional luaiso.cc: collectAllEntries
- Complex Conditional isobrowser.cc: PCSX::Widgets::IsoBrowser::drawFilesystemTree
- Complex Conditional isobrowser.cc: PCSX::Widgets::IsoBrowser::collectFlatEntries
- Complex Conditional isobrowser.cc: PCSX::Widgets::IsoBrowser::scanAllGaps
- Complex Method isobrowser.cc: PCSX::Widgets::IsoBrowser::collectFlatEntries
- Complex Method luaiso.cc: collectAllEntries
- Complex Method luaiso.cc: readerFindGaps
- Complex Method luaiso.cc: readerListDir
- Bumpy Road Ahead iso9660-reader.cc: PCSX::ISO9660Reader::ISO9660Reader
Annotations
Check warning on line 1 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Overall Function Size
The median function size in this module is 72.0 LOC, threshold = 50.0. This file contains overly long functions, measured by their lines of code.
Check warning on line 822 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
PCSX::Widgets::IsoBrowser::draw increases in cyclomatic complexity from 24 to 66, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 486 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
PCSX::Widgets::IsoBrowser::drawFilesystemFlat has a cyclomatic complexity of 46, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 303 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
PCSX::Widgets::IsoBrowser::scanAllGaps has a cyclomatic complexity of 43, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 137 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
PCSX::Widgets::IsoBrowser::drawFilesystemTree has a cyclomatic complexity of 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 162 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
PCSX::Widgets::IsoBrowser::collectFlatEntries has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 67 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
PCSX::Widgets::IsoBrowser::drawFilesystemTree has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 144 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
PCSX::Widgets::IsoBrowser::collectFlatEntries has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 284 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
PCSX::Widgets::IsoBrowser::scanAllGaps has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 822 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Bumpy Road Ahead
PCSX::Widgets::IsoBrowser::draw increases from 7 to 16 logical blocks with deeply nested code, threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 303 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
PCSX::Widgets::IsoBrowser::scanAllGaps has 7 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 486 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
PCSX::Widgets::IsoBrowser::drawFilesystemFlat has 6 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 137 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
PCSX::Widgets::IsoBrowser::drawFilesystemTree has 5 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 1 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Overall Code Complexity
This module has a mean cyclomatic complexity of 27.00 across 7 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check warning on line 822 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
PCSX::Widgets::IsoBrowser::draw has a nested complexity depth of 7, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check warning on line 303 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
PCSX::Widgets::IsoBrowser::scanAllGaps has a nested complexity depth of 6, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check warning on line 137 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
PCSX::Widgets::IsoBrowser::drawFilesystemTree has a nested complexity depth of 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check warning on line 486 in src/gui/widgets/isobrowser.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
PCSX::Widgets::IsoBrowser::drawFilesystemFlat has a nested complexity depth of 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check warning on line 164 in src/core/luaiso.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
collectAllEntries has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 210 in src/core/luaiso.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
readerFindGaps has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 108 in src/core/luaiso.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
readerListDir has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 74 in src/core/luaiso.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
stripSelfParent has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 149 in src/core/luaiso.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
collectAllEntries has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 62 in src/cdrom/iso9660-reader.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
PCSX::ISO9660Reader::ISO9660Reader has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.