Add PSYQo heap allocator viewer to Redux #2010
CodeScene PR Check
Quality Gate Failed
Gates Failed
New code is healthy
(1 new file with code health below 9.00)
Enforce critical code health rules
(1 file with Bumpy Road Ahead, Deep, Nested Complexity)
Enforce advisory code health rules
(4 files with Complex Method, Complex Conditional)
Gates Passed
1 Quality Gates Passed
See analysis details in CodeScene
Reason for failure
| New code is healthy | Violations | Code Health Impact | |
|---|---|---|---|
| heap_viewer.cc | 4 rules | 6.54 | Suppress |
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| heap_viewer.cc | 2 critical rules | 6.54 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| heap_viewer.cc | 2 advisory rules | 6.54 | Suppress |
| alloc.c | 1 advisory rule | 6.80 → 6.78 | Suppress |
| psxhw.cc | 1 advisory rule | 5.29 → 5.28 | Suppress |
| psxmem.cc | 1 advisory rule | 3.69 → 3.68 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional heap_viewer.cc: PCSX::Widgets::HeapViewer::walkHeap
- Complex Method psxhw.cc: PCSX::HW::write32
- Complex Method heap_viewer.cc: PCSX::Widgets::HeapViewer::draw
- Complex Method heap_viewer.cc: PCSX::Widgets::HeapViewer::walkHeap
- Complex Method alloc.c: psyqo_malloc
- Deep, Nested Complexity heap_viewer.cc: PCSX::Widgets::HeapViewer::draw
- Deep, Nested Complexity heap_viewer.cc: PCSX::Widgets::HeapViewer::walkHeap
- Bumpy Road Ahead heap_viewer.cc: PCSX::Widgets::HeapViewer::walkHeap
- Bumpy Road Ahead heap_viewer.cc: PCSX::Widgets::HeapViewer::draw
- Complex Conditional heap_viewer.cc: PCSX::Widgets::HeapViewer::draw
- Complex Method psxmem.cc: PCSX::Memory::reset
Annotations
Check warning on line 837 in src/core/psxhw.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
PCSX::HW::write32 increases in cyclomatic complexity from 53 to 54, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 177 in src/core/psxmem.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
PCSX::Memory::reset already has high cyclomatic complexity, and now it increases in Lines of Code from 77 to 78. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 384 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
PCSX::Widgets::HeapViewer::draw has a cyclomatic complexity of 49, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 188 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
PCSX::Widgets::HeapViewer::walkHeap has a cyclomatic complexity of 42, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 158 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
PCSX::Widgets::HeapViewer::walkHeap has 4 complex conditionals with 9 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 211 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
PCSX::Widgets::HeapViewer::draw has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 188 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
PCSX::Widgets::HeapViewer::walkHeap has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 384 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
PCSX::Widgets::HeapViewer::draw has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 384 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
PCSX::Widgets::HeapViewer::draw has a nested complexity depth of 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check warning on line 188 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
PCSX::Widgets::HeapViewer::walkHeap has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check warning on line 273 in src/mips/psyqo/src/alloc.c
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
psyqo_malloc increases in cyclomatic complexity from 12 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.