fix(release): MinVerTagPrefix=v so v* release tags stamp the real version - #77
Merged
Conversation
The release workflow triggers on 'v*' tags, but MinVer defaulted to an empty tag prefix and therefore ignored e.g. 'v1.0.0-rc.1', falling back to a 0.0.0-alpha height version. Without this, pushing a release tag would publish the wrong version to NuGet. Verified locally: a 'v1.0.0-rc.1' tag now packs as 1.0.0-rc.1.
SummarySummary
CoverageUniswapSharp - 85.2%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-publish fix caught by a local pack dry-run.
The
release.ymlworkflow fires onv*tags, but MinVer had noMinVerTagPrefix, so it didn't recognise thevprefix and fell back to a0.0.0-alpha.Nheight version. Result: pushingv1.0.0-rc.1would have published0.0.0-alpha.77to nuget.org — a wrong, unrecallable version.Setting
<MinVerTagPrefix>v</MinVerTagPrefix>fixes it. Verified locally (tag created, packed, deleted — never pushed):v1.0.0-rc.10.0.0-alpha.0.77❌1.0.0-rc.1✅One-line project property; no code or test impact.