fix(cli): refuse to write a container that would lose a broken task - #12
Merged
Merged
Conversation
A task whose frontmatter does not parse never enters the container's tasks array, so serializing that container writes the file back without it — the block is gone and nothing said so. Guard every write path (writeContainer, writeContainers, the rename path) against the parse problems collected for that file and fail with UNREADABLE_FRONTMATTER instead, naming the file so it can be fixed by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A task whose frontmatter fails to parse never enters the container's
tasksarray (seeparser.ts). Serializing and writing that container back to disk therefore silently drops the block — the task is gone and nothing indicates it.This guards every write path in
persistence.ts(writeContainer,writeContainers, and the rename path used e.g. when a release is renamed) against the collected parse problems for that file, and refuses to write with a newUNREADABLE_FRONTMATTERerror naming the offending file, instead of writing silently.Test plan
packages/cli/src/persistence.test.tsfor the new guard on all three write pathspackages/cli/src/app.test.tsfor the CLI-level behavior (refuse + error surfaced, message names the file)@grinev/boardown-clitest suite passes on top of currentmain(194/194)