fix: silence shellcheck SC2148 on tests/lib.sh - #13
Merged
Conversation
tests/lib.sh is meant to be sourced, not executed directly, so it intentionally has no shebang. shellcheck flags that as SC2148 once the file is actually git-tracked — it passed locally before commit only because `make lint` scopes to `git ls-files '*.sh'`, which skips untracked files. Add the `# shellcheck shell=bash` directive shellcheck recommends for sourced-only scripts instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI broke after #12 merged:
make lintfails with SC2148 ontests/lib.shbecause it's meant to be sourced (not executed directly) and intentionally has no shebang. This passed locally before commit only becausemake lintscopes togit ls-files '*.sh', which skips untracked files — the check was accidentally never run against the tracked version of this file until it landed on master.Fix: add the
# shellcheck shell=bashdirective shellcheck recommends for sourced-only scripts.Test plan
make lintpassesmake testpasses (all functional tests green)🤖 Generated with Claude Code