fix: resolve installer path bugs and shell-detection gaps - #10
Merged
Conversation
- install.sh: drop scan of nonexistent gcloud/ dir (gcloud.sh lives in tools/) - airbyte.sh: resolve docker.sh relative to script location, not caller cwd - gcloud.sh/terraform.sh/airbyte.sh: add pipefail so a failed curl in a pipe isn't silently swallowed by set -e - alias.txt/install_aliases.sh: replace hardcoded ~/Repositories/personal_utils path with a placeholder resolved to the actual clone location at install time - persist_env.sh: detect shell like install_aliases.sh does and read/write/ source the matching rc file instead of always hardcoding ~/.bashrc - README: drop the phantom gcloud folder from the directory table, document the zshrc/grep aliases
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan