Respect IMMU_SCOPE_WEIGHTS_DIR as first priority for determining ImmuScope weight directory - #1462
Open
susannasiebert wants to merge 1 commit into
Open
Respect IMMU_SCOPE_WEIGHTS_DIR as first priority for determining ImmuScope weight directory#1462susannasiebert wants to merge 1 commit into
susannasiebert wants to merge 1 commit into
Conversation
…Scope weight directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1461
This PR needs to be merged in conjunction with griffithlab/ImmuScope#1.
Currently, the logic in
resolved_immuscope_weights_dirdoesn't respect/take into accountIMMU_SCOPE_WEIGHTS_DIR. Instead onlyXDG_DATA_HOMEand the default~/.local/share'/ImmuScope/weightsare used. This PR updates the logic to first look atIMMU_SCOPE_WEIGHTS_DIR.IMMU_SCOPE_WEIGHTS_DIRis already the first priority for the weights directory when running the ImmuScope predictor via theimmuscope_wrapper.py. After merging in griffithlab/ImmuScope#1, this env variable will also be the first one to be used for downloading the weights.With this change in these two PRs the
IMMU_SCOPE_WEIGHTS_DIRwill now be consistently respected for downloading the weights and running ImmuScope inside of pVACtools.