Fix issue in the Transcript Pass logic that would cause pVACview to crash on retiering - #1459
Open
susannasiebert wants to merge 1 commit into
Open
Fix issue in the Transcript Pass logic that would cause pVACview to crash on retiering#1459susannasiebert wants to merge 1 commit into
susannasiebert wants to merge 1 commit into
Conversation
…rash on retiering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
apply(df$mainTable, TRUE ...instead ofapply(df$mainTable, 1 ...when calculatingtranscript_passstatus would cause pVACview to crash during re-tiering. This PR fixes that. It also centralizes the logic for this status by re-using the existingis_transcript_passfunction. Additionally, the exiting logic to add a new column for the results of this function during retiering would result in a second Transcript Pass column to be appended instead of the existing column to be updated. This PR fixes that.