Fix voltage level contextual menu in NAD #3625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
antoinebhs
reviewed
Dec 31, 2025
Comment on lines
25
to
27
| const studyUuid = useSelector((state: AppState) => state.studyUuid); | ||
| const currentNodeUuid = useSelector((state: AppState) => state.currentTreeNode)?.id; | ||
| const currentRootNetworkUuid = useSelector((state: AppState) => state.currentRootNetworkUuid); |
Contributor
There was a problem hiding this comment.
why not pass them from use-equipment-menu?
Contributor
Author
There was a problem hiding this comment.
I think it's better to do this way
It reduces the number of params that are necessary for the component to work anyway
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
antoinebhs
reviewed
Dec 31, 2025
| FEEDER_TYPES.GENERATOR, | ||
| ]; | ||
|
|
||
| export const equipmentsWithContextualMenu = [ |
Contributor
Author
There was a problem hiding this comment.
I removed too much code with my last commit while debugging
It's now used for white listing
antoinebhs
reviewed
Dec 31, 2025
antoinebhs
reviewed
Dec 31, 2025
| }; | ||
| }, [voltageLevel.id, studyUuid, currentNodeUuid, currentRootNetworkUuid]); | ||
|
|
||
| if (!voltageLevelInfos?.substationId || isLoading) { |
Contributor
There was a problem hiding this comment.
isLoading redundant with voltageLevelInfos?.substationId ?
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
antoinebhs
approved these changes
Dec 31, 2025
|
|
||
| const showEquipmentMenu = useCallback( | ||
| (svgId: string, equipmentId: string, equipmentType: string, mousePosition: Point) => { | ||
| // don't display the equipment menu in edit mode. |
Contributor
There was a problem hiding this comment.
delete outdated comment?
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Before this fix, voltage level menu was displaying empty string instead of substation ID in several submenus