shunt compensator creation dialog migration TS #3619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flomillot
requested changes
Dec 30, 2025
| [MAX_Q_AT_NOMINAL_V]: yup.number().nullable().min(0, 'ShuntCompensatorErrorQAtNominalVoltageLessThanZero'), | ||
| [MAX_SUSCEPTANCE]: yup.number().nullable(), | ||
| [MAXIMUM_SECTION_COUNT]: yup.number().min(1, 'MaximumSectionCountMustBeGreaterOrEqualToOne').nullable(), | ||
| [MAXIMUM_SECTION_COUNT]: yup.number().nullable().min(1, 'MaximumSectionCountMustBeGreaterOrEqualToOne'), |
Contributor
There was a problem hiding this comment.
Suggested change
| [MAXIMUM_SECTION_COUNT]: yup.number().nullable().min(1, 'MaximumSectionCountMustBeGreaterOrEqualToOne'), | |
| [MAXIMUM_SECTION_COUNT]: yup.number().min(1, 'MaximumSectionCountMustBeGreaterOrEqualToOne').nullable(), |
|
|
||
| export type CharacteristicsFormProps = { | ||
| previousValues?: ShuntCompensatorFormInfos; | ||
| isModification?: boolean; |
Contributor
There was a problem hiding this comment.
Suggested change
| isModification?: boolean; | |
| isModification: boolean; |
Why question mark if we have a default value ?
| const previousMaxQAtNominalV = useMemo(() => { | ||
| const previousValue = previousValues?.qatNominalV * previousValues?.maximumSectionCount; | ||
| return isNaN(previousValue) ? null : previousValue; | ||
| const prevValue = previousValues && previousValues?.qAtNominalV * previousValues?.maximumSectionCount; |
Contributor
There was a problem hiding this comment.
Suggested change
| const prevValue = previousValues && previousValues?.qAtNominalV * previousValues?.maximumSectionCount; | |
| const prevValue = previousValues && previousValues.qAtNominalV * previousValues.maximumSectionCount; |
| const previousMaxSusceptance = useMemo(() => { | ||
| const previousValue = previousValues?.bperSection * previousValues?.maximumSectionCount; | ||
| return isNaN(previousValue) ? null : previousValue; | ||
| const prevValue = previousValues && previousValues?.bPerSection * previousValues?.maximumSectionCount; |
| label={'SwitchedOnMaxQAtNominalV'} | ||
| adornment={ReactivePowerAdornment} | ||
| previousValue={previousValues?.qatNominalV * previousValues?.sectionCount} | ||
| previousValue={previousValues && previousValues?.qAtNominalV * previousValues?.sectionCount} |
| label={'SwitchedOnMaxSusceptance'} | ||
| adornment={SusceptanceAdornment} | ||
| previousValue={previousValues?.bperSection * previousValues?.sectionCount} | ||
| previousValue={previousValues && previousValues?.bPerSection * previousValues?.sectionCount} |
Contributor
There was a problem hiding this comment.
Same there is no need of question mark when you already checked if the value exists.
| [EQUIPMENT_ID]: yup.string().required(), | ||
| [EQUIPMENT_NAME]: yup.string().nullable(), | ||
| ...getConnectivityWithPositionValidationSchema(), | ||
| [CONNECTIVITY]: getConnectivityWithPositionSchema(), |
Contributor
There was a problem hiding this comment.
better to use the id field at as it's done for other function
Comment on lines
+43
to
+48
| [MAX_Q_AT_NOMINAL_V]?: number | null; | ||
| [MAX_SUSCEPTANCE]?: number | null; | ||
| [MAXIMUM_SECTION_COUNT]?: number | null; | ||
| [SECTION_COUNT]?: number | null; | ||
| [SWITCHED_ON_Q_AT_NOMINAL_V]?: number | null; | ||
| [SWITCHED_ON_SUSCEPTANCE]?: number | null; |
Contributor
There was a problem hiding this comment.
This is equivalent to number | null | undefined
We should do this only if null is different from optional and is a valid value
If the field is optional, we should remove this null type and use optional() instead of nullable() on the yup schema
| shuntCompensatorCreationInfos: ShuntCompensatorCreationInfos; | ||
| studyUuid: UUID; | ||
| nodeUuid: UUID; | ||
| modificationUuid?: string | null; |
Comment on lines
+506
to
+510
| maxSusceptance?: number | null; | ||
| maxQAtNominalV?: number | null; | ||
| shuntCompensatorType?: string | null; | ||
| sectionCount?: number | null; | ||
| maximumSectionCount?: number | null; |
Contributor
There was a problem hiding this comment.
Same, except if you have a good reason, you shouldn't use null with undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
shunt compensator creation dialog migration TS