chore: upgrade Node.js version to 24 across the project#648
Merged
softmarshmallow merged 3 commits intomainfrom Apr 8, 2026
Merged
chore: upgrade Node.js version to 24 across the project#648softmarshmallow merged 3 commits intomainfrom
softmarshmallow merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
WalkthroughUpgraded Node.js runtime version from 22 to 24 LTS across the project, including .nvmrc, package.json engine constraints, and Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Move onBrokenMarkdownLinks to markdown.hooks (v4 migration path) - Empty docs sync destination before copy to drop stale files and fix duplicate routes - Define missing doc tags in tags.yml; fix wasm-load-scene research link path - Fix @designto-code flag cross-links to sibling .md files; merge README into index for @designto-code and support Co-authored-by: Universe <universe@grida.co>
fix(docs): reduce Docusaurus build warnings
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/docs/scripts/docs-site-gen/copy-docs.js (1)
9-9:⚠️ Potential issue | 🟡 MinorFix typos to pass CI checks.
The pipeline is failing due to typos in this comment.
overrite→overwriteandsummury→summary.✏️ Proposed fix
- * overrite conflicting directories and files under that directory, and print summury of the result. + * overwrite conflicting directories and files under that directory, and print summary of the result.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/docs/scripts/docs-site-gen/copy-docs.js` at line 9, Fix the typos in the comment string shown in the diff: replace "overrite" with "overwrite" and "summury" with "summary" so the comment reads "...overwrite conflicting directories and files under that directory, and print summary of the result." Update the exact comment text in the file where this diff appears.
🧹 Nitpick comments (1)
docs/support/index.mdx (1)
1-11: Consider adding frontmatter for MDX compatibility.The file uses a
.mdxextension but contains no JSX/MDX features. To prevent potential build issues with angle brackets and opt out of unnecessary MDX parsing, consider addingformat: mdto the frontmatter.📝 Suggested frontmatter addition
+--- +format: md +--- + # SupportBased on learnings: For MDX compatibility, add
format: mdfrontmatter to documentation files that don't use JSX/MDX features to opt out of MDX parsing and prevent build issues with angle brackets.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/support/index.mdx` around lines 1 - 11, Add YAML frontmatter at the top of this MDX file to opt out of MDX parsing: insert a frontmatter block (---) containing format: md before the "Support" header so the parser treats the file as plain Markdown; ensure the frontmatter is closed with --- and followed by a blank line, leaving the existing content (the "Support" heading and body) unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/tags.yml`:
- Around line 194-197: The YAML tag key "lod" and label "LOD" are tripping the
typos linter; either add "lod" and "LOD" to the typos allowlist or rename the
tag to a full-word form. To fix, update the tags entry by replacing the key
"lod" and label "LOD" with a spelled-out identifier like "level_of_detail" and
label "Level of Detail" (and update permalink to something like
"/level-of-detail"), or alternatively add "lod" and "LOD" to your typo whitelist
configuration so the linter accepts the acronym.
---
Outside diff comments:
In `@apps/docs/scripts/docs-site-gen/copy-docs.js`:
- Line 9: Fix the typos in the comment string shown in the diff: replace
"overrite" with "overwrite" and "summury" with "summary" so the comment reads
"...overwrite conflicting directories and files under that directory, and print
summary of the result." Update the exact comment text in the file where this
diff appears.
---
Nitpick comments:
In `@docs/support/index.mdx`:
- Around line 1-11: Add YAML frontmatter at the top of this MDX file to opt out
of MDX parsing: insert a frontmatter block (---) containing format: md before
the "Support" header so the parser treats the file as plain Markdown; ensure the
frontmatter is closed with --- and followed by a blank line, leaving the
existing content (the "Support" heading and body) unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 70384b1d-9857-4a76-9c94-3ec6e4a95e69
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (26)
.github/workflows/realease-desktop-app.yml.nvmrcAGENTS.mdapps/backgrounds/package.jsonapps/blog/package.jsonapps/docs/docusaurus.config.tsapps/docs/package.jsonapps/docs/scripts/docs-site-gen/copy-docs.jsapps/viewer/package.jsoncrates/grida-canvas-wasm/package.jsondocs/@designto-code/README.mddocs/@designto-code/flags/--empty-content.mddocs/@designto-code/flags/--hash.mddocs/@designto-code/flags/--id.mddocs/@designto-code/flags/--ignore.mddocs/@designto-code/flags/--overflow.mddocs/@designto-code/flags/--scroll.mddocs/@designto-code/index.mddocs/support/README.mddocs/support/index.mdxdocs/tags.ymldocs/wg/feat-2d/wasm-load-scene-optimization.mdeditor/package.jsonpackage.jsonpackages/grida-canvas-transparency-grid/package.jsonpackages/grida-fonts/package.json
💤 Files with no reviewable changes (2)
- docs/@designto-code/README.md
- docs/support/README.md
Comment on lines
+194
to
+197
| lod: | ||
| label: LOD | ||
| permalink: /lod | ||
| description: Level-of-detail strategies for scene content and rendering. |
There was a problem hiding this comment.
Fix typo-lint blocker for lod tag.
typos is failing on this segment, so this PR cannot merge as-is. Either allowlist lod/LOD in typo config, or rename this tag to a fully spelled term to avoid lint failures.
✅ File-local fix option (avoid acronym in key/label)
-lod:
- label: LOD
+level-of-detail:
+ label: Level of detail
permalink: /lod
description: Level-of-detail strategies for scene content and rendering.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| lod: | |
| label: LOD | |
| permalink: /lod | |
| description: Level-of-detail strategies for scene content and rendering. | |
| level-of-detail: | |
| label: Level of detail | |
| permalink: /lod | |
| description: Level-of-detail strategies for scene content and rendering. |
🧰 Tools
🪛 GitHub Actions: typos
[error] 194-194: typos: lod should be load
[error] 195-195: typos: LOD should be LOAD
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/tags.yml` around lines 194 - 197, The YAML tag key "lod" and label "LOD"
are tripping the typos linter; either add "lod" and "LOD" to the typos allowlist
or rename the tag to a full-word form. To fix, update the tags entry by
replacing the key "lod" and label "LOD" with a spelled-out identifier like
"level_of_detail" and label "Level of Detail" (and update permalink to something
like "/level-of-detail"), or alternatively add "lod" and "LOD" to your typo
whitelist configuration so the linter accepts the acronym.
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Documentation