docs(htmlcss): expand CSS property reference and overhaul L0 fixtures#632
Merged
softmarshmallow merged 2 commits intomainfrom Apr 6, 2026
Merged
docs(htmlcss): expand CSS property reference and overhaul L0 fixtures#632softmarshmallow merged 2 commits intomainfrom
softmarshmallow merged 2 commits intomainfrom
Conversation
- Expand Text & Font section in htmlcss.md from 11 to ~75 properties across 9 sub-sections (font variants, text layout, decoration, emphasis, writing modes, inline alignment, ruby) - Convert all 30 L0 fixtures from branded dark theme to probe-friendly B/W high-contrast palette for headless testing - Rename 7 fixtures to follow <domain>-<property>[-<descriptor>] convention (flex-, filter-, inline-, list-, transform- domains) - Add grid-template.html fixture covering grid-template-columns/rows, fr units, repeat(), gap, spanning, auto-flow, and template-areas - Rewrite L0 README with domain taxonomy, authoring rules for probe-friendly fixture design, and updated template Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Covers what fixtures are, why we keep them, best practices for authoring probe-friendly fixtures, git inclusion policy (committed vs local-only), and the rule to never reference local-only fixtures in committed code or tests.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (34)
WalkthroughThis PR establishes fixture authoring guidelines and systematically updates test fixtures for the HTML/CSS renderer. It adds documentation on fixture best practices (SKILL.md), expands CSS property support documentation, updates the fixture README with new naming conventions and structural requirements, and applies consistent light-theme styling and high-contrast colors across 30+ HTML/CSS test fixtures. One new grid-template fixture is also added. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<domain>-<property>[-<descriptor>]naming convention (flex-,filter-,inline-,list-,transform-domains)grid-template.htmlfixture covering grid-template-columns/rows, fr units, repeat(), gap, spanning, auto-flow, and template-areas.agents/skills/fixtures/SKILL.md— general fixture authoring skill covering best practices, git inclusion policy, and local-only reference rulesTest plan
cargo test -p cg --lib -- htmlcss::tests --test-threads=1passes with updated fixturescargo run -p grida-dev -- fixtures/test-html/L0/mixed-card.htmlgrep -rl '#030712' fixtures/test-html/L0/🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
Documentation
Style