-
Notifications
You must be signed in to change notification settings - Fork 131
Embed viewer overhaul, Figma import fixes (geometry, strokes, lists), and CG bug fixes #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6935ef0
fix(embed): update iframe and embed source URLs from 'refig' to 'figma'
softmarshmallow 7047401
feat(embed): enhance embed functionality with new endpoints and file …
softmarshmallow 28f96a8
fix(io): build FeNoise table offsets outside FlatBuffers vector block
softmarshmallow 212ef5a
feat(tools): add Affine Transform Visualizer tool and update sitemap
softmarshmallow 7adc37d
feat(embed): add keyboard shortcuts for node navigation and viewport …
softmarshmallow d2df60a
fix(cg): include content origin offset in PathNode/Polygon/Vector geo…
softmarshmallow 6ad2760
feat(io-figma): support fillOverrideTable for per-region fill overrides
softmarshmallow 9f2fd3e
fix(cg): convert Container/Tray rotation from degrees to radians in s…
softmarshmallow b877113
fix(io-figma): propagate all non-identity container transforms into c…
softmarshmallow 7c0e48e
fix(io-figma): skip redundant strokeGeometry on BOOLEAN_OPERATION wit…
softmarshmallow 9f4c457
fmt
softmarshmallow de58e8c
feat(io-figma): faux-list rendering for Figma list import
softmarshmallow 3f58dae
docs(wg): document Figma strokeGeometry alignment as compositing inst…
softmarshmallow 28fff00
fix(io-figma): handle strokeAlign as compositing instruction via pain…
softmarshmallow 49dbcf7
Merge branch 'main' of https://github.com/gridaco/grida into canary
softmarshmallow 43f5844
merge chore
softmarshmallow 624cef8
feat(io-figma): implement INSIDE strokeAlign via boolean intersection
softmarshmallow 6f5f482
feat(uxhost-menu): enable geometry path preference in PlaygroundMenuC…
softmarshmallow 8815d39
wasm 0.91.0-canary.17
softmarshmallow a859954
fix test
softmarshmallow 7e00970
fix(io-figma): address PR review — AABB child rebase, H/V TODOs, doc …
softmarshmallow b6c7e31
refig - bump wasm
softmarshmallow ce1d9a6
docs(refig): enhance documentation for headless rendering and interac…
softmarshmallow 653d147
refactor(embed): update file conversion methods for in-memory processing
softmarshmallow 7b2fbe8
feat(cli): add convert command for Figma to Grida format conversion
softmarshmallow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Git LFS file not shown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
try/finallyto always dispose WASM scenes.If any assertion fails before Line 194, the scene is not disposed. Wrap the body in
try/finallyso cleanup is guaranteed.♻️ Suggested fix
for (const fixture of sharedFixtures) { it(`${fixture}: TS re-encode → WASM loadSceneGrida → switchScene`, async () => { @@ - const scene = createRasterScene(); - scene.loadSceneGrida(reEncoded); - - const wasmIds = scene.loadedSceneIds(); - expect(wasmIds).toContain(sceneId); - expect(() => scene.switchScene(sceneId)).not.toThrow(); - - scene.dispose(); + const scene = createRasterScene(); + try { + scene.loadSceneGrida(reEncoded); + + const wasmIds = scene.loadedSceneIds(); + expect(wasmIds).toContain(sceneId); + expect(() => scene.switchScene(sceneId)).not.toThrow(); + } finally { + scene.dispose(); + } }); }📝 Committable suggestion
🤖 Prompt for AI Agents