Replace snake-case and camelcase with change-case - #998
Open
stianjensen wants to merge 1 commit into
Open
Conversation
I noticed this PR still hanging gregberge#938, for this issue: gregberge#937 This should resolve the suggestions by replacing both these old packages with a new leaner one. Using version 4.x of change-case, as 5.x has done a rewrite to ESM-only. There is one behavior change in how pascalCase works (I haven't been able to find any alternative library that retains the behavior of the camelcase library wrt pascal-case after a leading number).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed this PR still hanging
#938, for this issue: #937
This should resolve the suggestions by replacing both these old packages with a new leaner one.
Using version 4.x of change-case, as 5.x has done a rewrite to ESM-only.
There is one behavior change in how pascalCase works (I haven't been able to find any alternative library that retains the behavior of the camelcase library wrt pascal-case after a leading number).
In the future, for instance after dropping node 18.x support (soon EOL), we can also target using change-case 5.x.
Test plan
I updated one assert here to reflect a behavior change in pascal-case. Let me know whether that is a dealbreaker and existing behavior needs to be retained in some way.