Skip to content

fix: parse storage ID from volid when deleting ISO/template #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenlogles merged 1 commit into from
Jul 16, 2026
Merged

fix: parse storage ID from volid when deleting ISO/template #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3344,12 +3344,11 @@ def api_delete_iso(node, volid):
return jsonify({"error": "Node not found"}), 404

try:
# volid format: storage/filename.iso
parts = volid.split("/")
if len(parts) != 2:
# volid format: storage:content-type/filename.iso (e.g. local:iso/foo.iso)
if ":" not in volid or "/" not in volid:
return jsonify({"error": "Invalid volume ID format"}), 400

storage = parts[0]
storage = volid.split(":")[0]
proxmox.nodes(node).storage(storage).content(volid).delete()

return jsonify(
Expand Down Expand Up @@ -3395,12 +3394,12 @@ def api_delete_lxc_template(node, volid):
return jsonify({"error": "Node not found"}), 404

try:
# volid format: storage/template-name.tar.xz
parts = volid.split("/")
if len(parts) != 2:
# volid format: storage:content-type/template-name.tar.xz
# (e.g. local:vztmpl/debian-12.tar.zst)
if ":" not in volid or "/" not in volid:
return jsonify({"error": "Invalid volume ID format"}), 400

storage = parts[0]
storage = volid.split(":")[0]
proxmox.nodes(node).storage(storage).content(volid).delete()

return jsonify(
Expand Down
2 changes: 1 addition & 1 deletion static/js/isos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export function isosManager() {
// ── Display helpers ───────────────────────────────────────────────────────

isoFilename(volid) { return (volid || '').split('/').pop(); },
isoStorage(volid) { return (volid || '').split('/')[0] || ''; },
isoStorage(volid) { return (volid || '').split(':')[0] || ''; },
isoSizeGB(iso) { return iso.size ? (iso.size / 1073741824).toFixed(2) : 'Unknown'; },
vmMemGB(vm) { return vm.maxmem ? (vm.maxmem / 1073741824).toFixed(1) : 'Unknown'; },
vmCpuInfo(vm) { return vm.cpus ? `${vm.cpus} cores` : 'Unknown'; },
Expand Down
Loading