feat: report 1-based line number with each finding - #5
Open
Chirudeva-Reddy wants to merge 2 commits into
Open
Chirudeva-Reddy wants to merge 2 commits into
Chirudeva-Reddy wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #4. Findings previously identified the file and gas name, but omitted the line number within the file. In larger files or CI/editor integrations, 1-based line numbers allow direct inline annotations and fast navigation to the offending cell.
Changes
records(): Tracked running character offsets acrossre.split(r"[{}]", text)blocks rather than searching the text again, preserving absolute line positions even across repeated rows.basis_maps(): UsedENTRY.finditerinsideBASIS_MAP.finditerto capture exact entry line numbers per report basis.tables(): Tracked row line numbers across HTML (<tr...>viare.finditer), Markdown (splitlines()row indices), and CSV formats.line(1-based integer) to each finding in--jsonoutput.line <N>: ...).Verification
python3 gwp_basis_check.py --self-test: All 9 existing test cases plus the new line-number test case pass.python3 render_tables.py --check: README tables match reference.python3 gwp_basis_check.py README.md: Passes cleanly.--json.