Skip to content

Keep the intent approval screen off the database - #619

Merged
greenart7c3 merged 1 commit into
masterfrom
refactor/intent-screen-off-database
Nov 20, 2026
Merged

greenart7c3 merged 1 commit into
masterfrom
refactor/intent-screen-off-database

Conversation

@greenart7c3

Copy link
Copy Markdown
Owner

Starts step 6 of docs/architecture.md, keep ui/ off the database (added in this PR): six screens are still on the databaseInUi allow-list of the architecture test, against the target layering where the UI only talks to ViewModels.

First one: IntentSingleEventHomeScreen held the caller's ApplicationWithPermissions (loaded by its ViewModel) to read the app name and work out the remembered decision. LoadedIntentApplication now keeps the entity private and exposes only:

  • name
  • remembered(key, relayUrl): the same isRemembered(signPolicy, intentPermission(...)) the screen computed

The screen no longer imports database/ and leaves the allow-list (−1 entry). With nothing loaded (a browser deep link, or before the load) the decision is still null (ask), as before.

IntentSingleEventViewModelTest compares the whole loaded value instead of reading the entity. No behaviour change: free and offline unit tests, :architecture-tests:test, detektAll and the pre-push test lint pass.

IntentSingleEventHomeScreen held the caller's ApplicationWithPermissions.
LoadedIntentApplication now keeps it private and gives the screen the saved
name and remembered(key, relayUrl), so the screen leaves the databaseInUi
allow-list. Adds step 6 (keep ui/ off the database) to the roadmap. No
behaviour change.
@greenart7c3
greenart7c3 merged commit 2631d02 into master Nov 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant