Repository navigation
Keep the intent approval screen off the database - #619
Merged
Merged
Conversation
IntentSingleEventHomeScreen held the caller's ApplicationWithPermissions. LoadedIntentApplication now keeps it private and gives the screen the saved name and remembered(key, relayUrl), so the screen leaves the databaseInUi allow-list. Adds step 6 (keep ui/ off the database) to the roadmap. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts step 6 of docs/architecture.md, keep
ui/off the database (added in this PR): six screens are still on thedatabaseInUiallow-list of the architecture test, against the target layering where the UI only talks to ViewModels.First one:
IntentSingleEventHomeScreenheld the caller'sApplicationWithPermissions(loaded by its ViewModel) to read the app name and work out the remembered decision.LoadedIntentApplicationnow keeps the entity private and exposes only:nameremembered(key, relayUrl): the sameisRemembered(signPolicy, intentPermission(...))the screen computedThe screen no longer imports
database/and leaves the allow-list (−1 entry). With nothing loaded (a browser deep link, or before the load) the decision is still null (ask), as before.IntentSingleEventViewModelTestcompares the whole loaded value instead of reading the entity. No behaviour change: free and offline unit tests,:architecture-tests:test,detektAlland the pre-pushtest lintpass.