Skip to content

Analyse static functions, and stop merging them into the function above #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rganz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Analyse static functions, and stop merging them into the function above #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions addons/gdscript-linter/analyzer/checkers/function-checker.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ func analyze_functions(lines: Array, file_result, add_issue_callback: Callable,
var line: String = lines[i]
var trimmed := line.strip_edges()

# A static function is a function. Matching only "func " meant a static
# declaration never opened a new function, so its body was appended to the
# function above it and the static one was never analysed. Normalising here
# keeps the substr(5) assumption in _parse_function_signature valid.
if trimmed.begins_with("static func "):
trimmed = trimmed.substr(7)

if trimmed.begins_with("func "):
# Finalize previous function
if in_function and current_func:
Expand Down