feat: improve button a11y with aria labels #920
Merged
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PosikBoy
changed the title
Contributor
Author
|
That was fast) |
|
|
d3m1d0v
reviewed
Jan 13, 2026
src/i18n/bundle/en.json
Outdated
Comment on lines
11
to
12
| "preview_hint": "Preview", | ||
| "settings_label": "Settings" |
Member
There was a problem hiding this comment.
I think it would be better to name both keys similarly: preview_label, settings_label
Member
There was a problem hiding this comment.
Something went wrong - checks failed
Member
There was a problem hiding this comment.
"preview_label" in en.json
but "preview_hint" in ru.json
makhnatkin
approved these changes
Jan 13, 2026
makhnatkin
changed the title
makhnatkin
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #919