Fix Desktop Text Boxes on XfDesktop 4.20+#419
Open
8bitredstone wants to merge 1 commit intograssmunk:masterfrom
Open
Fix Desktop Text Boxes on XfDesktop 4.20+#4198bitredstone wants to merge 1 commit intograssmunk:masterfrom
8bitredstone wants to merge 1 commit intograssmunk:masterfrom
Conversation
The bounding box was changed in XFCE roughly 2 years ago, so the hard coded numbers need to be updated. These numbers ensure there is always a highlight of at least 1 pixel around text, in line with how Windows 95 looks. See screenshots here (using the recommended Helvetica font on size 8 and 10): https://imgur.com/a/J1Zn71H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bounding box was changed in XFCE roughly 2 years ago, so the hard coded numbers need to be updated. These values ensure there is always a highlight of at least 1 pixel around text, in line with how Windows 95 looks.
Before and after using Helvetica font on size 10:
Before and after using Helvetica font on size 8:
