Skip to content

Add ChilliCream Duration scalar and deprecate TimeSpan - #68

Merged
martinbonnin merged 2 commits into
graphql:mainfrom
glen-84:rename-time-span-to-duration
Mar 19, 2026
Merged

Add ChilliCream Duration scalar and deprecate TimeSpan#68
martinbonnin merged 2 commits into
graphql:mainfrom
glen-84:rename-time-span-to-duration

Conversation

@glen-84

@glen-84 glen-84 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Duration better matches the underlying spec. TimeSpan was .NET-oriented.

@martinbonnin

Copy link
Copy Markdown
Contributor

time-span has been around for ~2 months. Deleting it would be a breaking change as specifications in this repository are immutable.

Instead, you can keep time-span with a clear deprecation notice.

@glen-84

glen-84 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

I can do that ... although TBH there is an extremely small chance that someone actually referenced this specification.

@martinbonnin

Copy link
Copy Markdown
Contributor

there is an extremely small chance that someone actually referenced this specification

I agree but I'd rather not create a precedent. We have to get used that those specifications are immutable.

Let's invest in better tooling to deprecate/redirect older versions.

@glen-84

glen-84 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

I added:

Status – Deprecated (replaced by Duration)

Not sure exactly how you want to do it?

@glen-84 glen-84 changed the title Rename ChilliCream TimeSpan scalar to Duration Add ChilliCream Duration scalar and deprecate TimeSpan Mar 9, 2026
@martinbonnin

Copy link
Copy Markdown
Contributor

Not sure exactly how you want to do it?

This looks good to me! Maybe put it in bold?

Later on, we might want some machine readable format to hide the deprecated specifications from the index (or merge with https://github.com/graphql/gaps/). But this is longer term. Your current sentence looks good to me 👍

@glen-84

glen-84 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

Maybe put it in bold?

You can play around with it if you like ... making the whole sentence bold sort of conflicts with the License and Copyright text below it, unless you meant just making the word Deprecated bold?

@martinbonnin

Copy link
Copy Markdown
Contributor

I have no clue sorry 😅 I just wanted to make sure people didn't miss it. But I'm fine with leaving it as is.

@glen-84

glen-84 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Can this be merged now? 🙂

@martinbonnin

martinbonnin commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Yep, let's merge. I'll also remove that 2 weeks review period, which hasn't been super helpful and just adds friction.

Edit: #70

@martinbonnin
martinbonnin merged commit 01d9914 into graphql:main Mar 19, 2026
5 checks passed
@glen-84
glen-84 deleted the rename-time-span-to-duration branch March 19, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants