Skip to content

Use Object.create(null) over {} to avoid prototype issues #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaacovCR merged 2 commits into from
Apr 16, 2026
Merged

Use Object.create(null) over {} to avoid prototype issues #4634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45e66f1
Use Object.create(null) over {} to avoid prototype issues
benjie Mar 24, 2026
3ee6c94
remove prototype from `args` map, coerced input values/literals
yaacovCR Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/execution/values.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ export function getArgumentValues(
variableValues?: Maybe<VariableValues>,
fragmentVariableValues?: Maybe<FragmentVariableValues>,
hideSuggestions?: Maybe<boolean>,
): { [argument: string]: unknown } {
const coercedValues: { [argument: string]: unknown } = {};
): ObjMap<unknown> {
const coercedValues: ObjMap<unknown> = Object.create(null);

const argumentNodes = node.arguments ?? [];
const argNodeMap = new Map(argumentNodes.map((arg) => [arg.name.value, arg]));
Expand Down
5 changes: 3 additions & 2 deletions src/utilities/coerceInputValue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { invariant } from '../jsutils/invariant.js';
import { isIterableObject } from '../jsutils/isIterableObject.js';
import { isObjectLike } from '../jsutils/isObjectLike.js';
import type { Maybe } from '../jsutils/Maybe.js';
import type { ObjMap } from '../jsutils/ObjMap.js';

import type { ValueNode, VariableNode } from '../language/ast.js';
import { Kind } from '../language/kinds.js';
Expand Down Expand Up @@ -69,7 +70,7 @@ export function coerceInputValue(
return; // Invalid: intentionally return no value.
}

const coercedValue: any = {};
const coercedValue: ObjMap<unknown> = Object.create(null);
const fieldDefs = type.getFields();
const hasUndefinedField = Object.keys(inputValue).some(
(name) => !Object.hasOwn(fieldDefs, name),
Expand Down Expand Up @@ -211,7 +212,7 @@ export function coerceInputLiteral(
return; // Invalid: intentionally return no value.
}

const coercedValue: { [field: string]: unknown } = {};
const coercedValue: ObjMap<unknown> = Object.create(null);
const fieldDefs = type.getFields();
const hasUndefinedField = valueNode.fields.some(
(field) => !Object.hasOwn(fieldDefs, field.name.value),
Expand Down
Loading