feat(incremental): do not initiate multiple streams at the same path - #3830
Closed
yaacovCR wants to merge 8 commits into
Closed
feat(incremental): do not initiate multiple streams at the same path#3830yaacovCR wants to merge 8 commits into
yaacovCR wants to merge 8 commits into
Conversation
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yaacovCR
force-pushed
the
do-not-multi-stream
branch
3 times, most recently
from
January 17, 2023 12:12
b63c09a to
34ff573
Compare
presumably we should do this
avoids needlessly rechecking whether a stream has begun
yaacovCR
force-pushed
the
do-not-multi-stream
branch
from
February 6, 2023 13:03
34ff573 to
835fa56
Compare
Contributor
Author
|
closing this in favor of #3862 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds upon the defer merging work in #3820.
The following operation:
will now only result in a single stream.
Corresponding spec change is at: robrichard/graphql-spec#12