Skip to content

feat(incremental): do not initiate multiple streams at the same path - #3830

Closed
yaacovCR wants to merge 8 commits into
graphql:mainfrom
yaacovCR:do-not-multi-stream
Closed

feat(incremental): do not initiate multiple streams at the same path#3830
yaacovCR wants to merge 8 commits into
graphql:mainfrom
yaacovCR:do-not-multi-stream

Conversation

@yaacovCR

@yaacovCR yaacovCR commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

This builds upon the defer merging work in #3820.

The following operation:

query { 
  friendList @stream(initialCount: 2) {
    name
    id
  }
  ... @defer {
    friendList @stream(initialCount: 2) {
      name
      id
    }
  }
}

will now only result in a single stream.

Corresponding spec change is at: robrichard/graphql-spec#12

@github-actions

Copy link
Copy Markdown

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@netlify

netlify Bot commented Jan 17, 2023

Copy link
Copy Markdown

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 835fa56
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63e0fa99f60f670008eb8b30
😎 Deploy Preview https://deploy-preview-3830--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yaacovCR
yaacovCR force-pushed the do-not-multi-stream branch from 34ff573 to 835fa56 Compare February 6, 2023 13:03
@yaacovCR

Copy link
Copy Markdown
Contributor Author

closing this in favor of #3862

@yaacovCR yaacovCR closed this Mar 30, 2023
@yaacovCR
yaacovCR deleted the do-not-multi-stream branch September 5, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant