demonstrate removal of TaggedFieldNode - #3826
Closed
yaacovCR wants to merge 7 commits into
Closed
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yaacovCR
force-pushed
the
hoist-depth
branch
9 times, most recently
from
January 15, 2023 20:07
b1882c2 to
c675033
Compare
yaacovCR
changed the title
Contributor
Author
|
This PR now demonstrates conversion of: export type FieldGroup = ReadonlyArray<TaggedFieldNode>;
export interface TaggedFieldNode {
fieldNode: FieldNode;
depth: number;
deferDepth: number | undefined;
}to export interface FieldGroup {
depth: number;
fields: Map<number | undefined, ReadonlyArray<FieldNode>>;
} |
presumably we should do this
Contributor
Author
|
consolidating into #3844 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
less repetition, but takes another destructuring to get at the fields within a field set....