polish: a few smaller refactors - #3756
Closed
yaacovCR wants to merge 5 commits into
Closed
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yaacovCR
added
the
PR: polish 💅
yaacovCR
force-pushed
the
simple-refactors
branch
from
October 12, 2022 09:31
70d4963 to
4af125d
Compare
saihaj
approved these changes
Oct 13, 2022
yaacovCR
force-pushed
the
simple-refactors
branch
from
October 18, 2022 10:04
7442471 to
24ce84d
Compare
to improve readability
addError calls locatedError and then adds the error as previously in handleFieldError, throwing if the type is non-null. As opposed to handleFieldError, it does not return null, so as to require the calling function to be more explicit about the new value.
yaacovCR
force-pushed
the
simple-refactors
branch
3 times, most recently
from
January 3, 2023 13:34
5d17294 to
41f5420
Compare
yaacovCR
force-pushed
the
simple-refactors
branch
from
January 3, 2023 14:27
41f5420 to
86a84ac
Compare
| const error = locatedError(rawError, fieldNodes, pathToArray(path)); | ||
| const handledError = handleFieldError(error, returnType, errors); | ||
| const errors = asyncPayloadRecord?.errors ?? exeContext.errors; | ||
| addError(rawError, fieldNodes, returnType, path, errors); |
Member
There was a problem hiding this comment.
Not sure about this one, especially since addError throws located error.
But since it's not a public API, let's try and merge it.
Future suggestion: If we convert ExecutionContext into class it can have single method called handleFieldError that:
locateError- push error into
errors filterSubsequentPayloads
IvanGoncharov
approved these changes
Jan 5, 2023
IvanGoncharov
left a comment
IvanGoncharov
left a comment
Member
There was a problem hiding this comment.
Makes sense 👍
@yaacovCR Thank you for extracting it 🙇
Contributor
Author
|
Probably makes sense to wait on this until #3815 is approved, which could require a spec change. Filtering is complex! |
Contributor
Author
|
refactors 3 and 4 from this were merged in #3878 some of the remaining minor changes from this refactoring PR perhaps could be revisited, but I am closing this stale PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
completeAsyncIteratorValueto better reflect what might throw.next()callshandleErrorhelper withaddErrorwith the new function also callinglocatedErrorhandleRawErrorhelper which also includes filtering of async payloadsextracted from #3754