Clone Context on each GraphQL subscription execution#1369
Merged
tyranron merged 5 commits intographql-rust:masterfrom Mar 8, 2026
Merged
Clone Context on each GraphQL subscription execution#1369tyranron merged 5 commits intographql-rust:masterfrom
Context on each GraphQL subscription execution#1369tyranron merged 5 commits intographql-rust:masterfrom
Conversation
Contributor
Author
FCMClone `Context` for each GraphQL subscription in `juniper_graphql_ws` crate (#1369) |
# Conflicts: # juniper_actix/CHANGELOG.md # juniper_graphql_ws/CHANGELOG.md
Contributor
Author
|
@tyranron Looks like I forgot to update trait bounds in tests. Can take the PR back to Draft to fix tests? |
tyranron
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis
Context in
juniper_graphql_wsshared across multiple GraphQL subscriptions in same WebSocket connection, which causes problems with defining subscription-local data.Solution
Clone
Contextfor each GraphQL subscription in WebSocket connection. It will allow end-user to control the context scope:Arc;impl Clone for Context.Checklist