Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request removes event.preventDefault() from the vite:preloadError listener in packages/web/app/src/main.tsx. This allows errors to propagate to unhandledrejection and error-boundary handlers, avoiding cryptic TypeErrors from Vite's silent branch. I have no feedback to provide.
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/laboratory |
0.1.4-alpha-20260416231425-917ad40400f4a0596698af4855a5242824fd459d |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/render-laboratory |
0.1.4-alpha-20260416231425-917ad40400f4a0596698af4855a5242824fd459d |
npm ↗︎ unpkg ↗︎ |
hive |
11.0.3-alpha-20260416231425-917ad40400f4a0596698af4855a5242824fd459d |
npm ↗︎ unpkg ↗︎ |
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
n1ru4l
approved these changes
Apr 17, 2026
n1ru4l
deleted the
console-2025-stale-chunk-loads-surface-as-typeerror-cannot-destructure
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
event.preventDefault()from the vite:preloadError handler inmain.tsx(keepingreloadOnChunkError()).preventDefault()made failed dynamic imports resolve to undefined, causing destructures likeconst { SchemaEditor } = await import(...)to throw a cryptic TypeError before the reload fired. Letting the error propagate routes it through the existing unhandled rejection / error-boundary paths, which already reload and are filtered by Sentry.