Skip to content

feat: create initial collection prompt + edit name#7989

Merged
mskorokhodov merged 6 commits intomainfrom
feat/lab-collections
Apr 17, 2026
Merged

feat: create initial collection prompt + edit name#7989
mskorokhodov merged 6 commits intomainfrom
feat/lab-collections

Conversation

@mskorokhodov
Copy link
Copy Markdown
Collaborator

@mskorokhodov mskorokhodov commented Apr 16, 2026

Background

Description

Enhanced collection create/edit experience

Screen.Recording.2026-04-17.at.10.34.37.mov

Checklist

  • Input validation
  • Output encoding
  • Authentication management
  • Session management
  • Access control
  • Cryptographic practices
  • Error handling and logging
  • Data protection
  • Communication security
  • System configuration
  • Database security
  • File management
  • Memory management
  • Testing

@mskorokhodov mskorokhodov marked this pull request as draft April 16, 2026 10:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/laboratory 0.1.5-alpha-20260417103319-e59a05597bf8e94d355e37aac3996a92eaf33bbd npm ↗︎ unpkg ↗︎
@graphql-hive/render-laboratory 0.1.5-alpha-20260417103319-e59a05597bf8e94d355e37aac3996a92eaf33bbd npm ↗︎ unpkg ↗︎

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to rename laboratory collections and enhances the "Save to collection" workflow with an empty state and a shortcut to create new collections. Feedback focuses on resolving accessibility and HTML validity issues caused by nested interactive elements within CollapsibleTrigger and TooltipTrigger. Additionally, improvements are suggested for the editing experience, such as handling the Escape key, resetting state upon cancellation, and using controlled inputs to prevent stale values.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: e59a05597bf8e94d355e37aac3996a92eaf33bbd

@mskorokhodov mskorokhodov force-pushed the feat/lab-collections branch from b898773 to 03d983d Compare April 17, 2026 08:45
@mskorokhodov mskorokhodov marked this pull request as ready for review April 17, 2026 08:47
@mskorokhodov mskorokhodov requested a review from n1ru4l April 17, 2026 08:53
@mskorokhodov mskorokhodov force-pushed the feat/lab-collections branch from 772121d to e59a055 Compare April 17, 2026 10:32
@mskorokhodov mskorokhodov merged commit 863f920 into main Apr 17, 2026
24 checks passed
@mskorokhodov mskorokhodov deleted the feat/lab-collections branch April 17, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants