fix(layout): preserve user-set play URL parameter in ring layouts#849
Open
fix(layout): preserve user-set play URL parameter in ring layouts#849
Conversation
aucahuasi
reviewed
Nov 26, 2025
| if play_ms != 0: | ||
| play_value = play_ms | ||
| elif 'play' in g._url_params: | ||
| play_value = g._url_params['play'] |
Contributor
There was a problem hiding this comment.
Can we parse the play value or make sure it has a valid format?
aucahuasi
requested changes
Nov 26, 2025
aucahuasi
requested changes
Nov 27, 2025
Contributor
aucahuasi
left a comment
aucahuasi
left a comment
There was a problem hiding this comment.
Thanks, can you add some tests as well?
lmeyerov
reviewed
Nov 28, 2025
|
|
||
| if play_ms != 0: | ||
| play_value = play_ms | ||
| elif 'play' in g._url_params: |
Contributor
There was a problem hiding this comment.
This looks wrong - if 0 is set, we should respect it
I can imagine changing the type signature to : Optional[int] = 0, and having None mean "honor url param if already set, otherwise default to 0", but that feels unnecessarily complicated
Contributor
|
See comment for cleaner way to support cascading - do when None Also I thought we have 3-4 ring layout variants ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where &play option does not update in URL param