Draft
Conversation
lmeyerov
reviewed
Jun 13, 2024
|
|
||
| def try_coerce_to_numeric(ndf: pd.DataFrame): | ||
| try: | ||
| nndf = ndf.copy() |
lmeyerov
reviewed
Jun 13, 2024
| nndf = ndf.copy() | ||
| object_columns = nndf.select_dtypes(include=['object']).columns | ||
| for j in object_columns: | ||
| num_floats = sum(isinstance(x, float) for x in nndf[j].dropna()) |
Contributor
There was a problem hiding this comment.
This is slow, and weird to check for floats in a col marked as object?
lmeyerov
reviewed
Jun 13, 2024
Contributor
lmeyerov
left a comment
lmeyerov
left a comment
There was a problem hiding this comment.
@silkspace @tanmoyio this seems slow and surprising to put in the critical path for most gpu umap calls?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for rare cases first encountered in avr-59k['Source_IP4_Subnet_16'] dataset, for example
graphistry.nodes(avr59k_splunk['Source_IP4_Subnet_16'].dropna()).umap()would throw type error
see end of this thread