Repository navigation
A product page reached through a category path keeps core's product URL - #45
Merged
Merged
Conversation
The document model took its category ids from the category product index, which adds the anchor ancestors, so the page's category applied where core's assignments do not and the product URL took the category path. The model now takes the product's category assignments, as core does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude Code:
With "Use Categories Path for Product URLs" on, a product page reached through a category path rendered the category URL on the documents path (
og:url, the Organization JSON-LD), where core renders the product's own URL.Product::getCategoryId()applies the current category only whengetCategoryIds()contains it. Core readscatalog_category_product. The document model tookcategoryIds, the category product index, which adds the anchor ancestors. So on/women/tops-women/breathe-easy-tank, category 25 applied on the documents path only.The products feed now carries
categoryAssignmentIds(Provider/CategoryAssignments, the rows ofcatalog_category_product), and the model'scategory_idstakes them.categoryIdsstays the index for the readers that need it. Theet_schema.xmlchange re-exports every product row.Verified: listing and detail parity gates identical at MAX_REQUESTS 1 and 3. The documents path read product documents on every page, with no
catalog_category_productread and no change in SQL count.🤖 Generated with Claude Code