Repository navigation
Bundle selections of a product page leave out children that are not salable - #40
Merged
Merged
Conversation
… shows: a selection whose child is not salable is left out unless the store shows out of stock products, as core's stock filter leaves it out, so an option with one salable selection renders as that selection and not as a list with a disabled entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude Code:
OptionsFromDocumentleaves out a selection whose child is not salable, unless the store shows out of stock products. Core's stock filter does this on the selections collection, andBundleItemsFromDocument(GraphQL) already does it on the document path. Before, a Hyvä bundle page on the document path listed the selection as a disabled entry, and an option with one salable selection rendered as a select instead of the fixed selection.catalog-storefront:parity:detailon a Hyvä shop: 10 of 10 random bundle pages identical (before: 4837 differing lines on the first one).🤖 Generated with Claude Code