Repository navigation
Configurable parents of listing cards from documents - #39
Merged
Merged
Conversation
…s from the documents, so a category or search page on Hyvä runs no query per card for its cache tags: core's identities plugin asked the parents of every simple product a card tags, 46 queries on every render of a 48 card page, also when the block cache hit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude Code:
ConfigurableProductFrontendanswersgetParentIdsByChild()from theparentIdsof the page's card documents and the variant documents of its cards. Core'sProductIdentitiesExtenderasks it for every simple product whose identities a card collects (Hyvä callsgetIdentities()per card for its block cache), onecatalog_product_super_linkquery each, also when the card's block cache hits. A product without such a document goes to core.Measured on a Hyvä shop (107 815 products), warm block cache, document path:
catalog-storefront:parity:listingis identical on 5 of 5 pages. A check of 2000 random simple products againstcatalog_product_super_linkgives the same parents for every product.🤖 Generated with Claude Code