Skip to content

test: cover graph-ref alias boundaries with and without overlay bindings - #2042

Merged
shunichironomura merged 1 commit into
mainfrom
test/source-graph-ref-alias-boundaries
Oct 11, 2026
Merged

shunichironomura merged 1 commit into
mainfrom
test/source-graph-ref-alias-boundaries

Conversation

@shunichironomura

Copy link
Copy Markdown
Member

Warning

This content was written by an AI agent and must be verified by a human developer. After human verification, this alert may be removed.

Summary

  • Adds an HIR expression-lowering test with four cases: @imported::name may read only instance-independent consts, and @included::name may read graph values. Each rule is checked twice: when the module resolver reaches the path, and when an overlay binding the resolver cannot see supplies it.
  • This is the test from refactor: preserve resolver source-path boundaries #2037, kept on its own. The resolver refactor in that PR was dropped as not worth doing; see the closing comment on Classify alias.member once during HIR lowering #1952. Test-only change: no compiler, diagnostic or editor behavior changes.

Validation

  • cargo fmt --all --check, cargo clippy -p graphcal-compiler --tests -- -D warnings, and cargo test -p graphcal-compiler --lib hir::expr_lower (30 passed) all pass.

AI assistance

Breaking changes

  • No breaking changes
  • Breaking changes; the breaking change label is applied

🤖 Generated with Claude Code

https://claude.ai/code/session_01B2t1wANbEx5VhUyvdThmbW


Generated by Claude Code

Pin that `@imported::name` may read only instance-independent consts and
`@included::name` may read graph values, both when the resolver reaches the
path and when an overlay binding the resolver cannot see supplies it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B2t1wANbEx5VhUyvdThmbW
@shunichironomura
shunichironomura enabled auto-merge (squash) October 11, 2026 02:09
@shunichironomura
shunichironomura merged commit 51fd9ef into main Oct 11, 2026
47 checks passed
@shunichironomura
shunichironomura deleted the test/source-graph-ref-alias-boundaries branch October 11, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants