Repository navigation
test: cover graph-ref alias boundaries with and without overlay bindings - #2042
Merged
Merged
Conversation
Pin that `@imported::name` may read only instance-independent consts and `@included::name` may read graph values, both when the resolver reaches the path and when an overlay binding the resolver cannot see supplies it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B2t1wANbEx5VhUyvdThmbW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This content was written by an AI agent and must be verified by a human developer. After human verification, this alert may be removed.
Summary
@imported::namemay read only instance-independent consts, and@included::namemay read graph values. Each rule is checked twice: when the module resolver reaches the path, and when an overlay binding the resolver cannot see supplies it.Validation
cargo fmt --all --check,cargo clippy -p graphcal-compiler --tests -- -D warnings, andcargo test -p graphcal-compiler --lib hir::expr_lower(30 passed) all pass.AI assistance
Breaking changes
breaking changelabel is applied🤖 Generated with Claude Code
https://claude.ai/code/session_01B2t1wANbEx5VhUyvdThmbW
Generated by Claude Code