Repository navigation
refactor: remove unused eval public accessors - #2038
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This content was written by an AI agent and must be verified by a human developer. After human verification, this alert may be removed.
Summary
Remove three unused APIs from
graphcal-eval:RuntimeEvaluation::resultValue::dimensionHostArray::into_partsPartially addresses #1949; the white-box test migrations remain open. Relates to #1947. This is the lower branch of the stack beneath #2037 and contains only the API removals.
Validation
Fresh
just lintandjust testruns passed on the combined workspace stack before opening this PR. CI will validate this branch independently.AI assistance
Breaking changes
breaking changelabel is applied