Give plugin errors W codes and module resolution M036 (#1968)

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__ambiguous_bare_index_label.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::M033",
+    "code": "graphcal::M036",
     "labels": [
       {
         "length": 1,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__complex_extern_unsupported.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P001",
+    "code": "graphcal::W001",
     "labels": [
       {
         "length": 15,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_array_concrete_index.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P001",
+    "code": "graphcal::W001",
     "labels": [
       {
         "length": 8,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_array_unbound_result_index.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P001",
+    "code": "graphcal::W001",
     "labels": [
       {
         "length": 40,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_conflicting_signature.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P001",
+    "code": "graphcal::W001",
     "labels": [
       {
         "length": 79,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_duplicate_param.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P011",
+    "code": "graphcal::W011",
     "labels": [
       {
         "length": 1,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_in_const.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P004",
+    "code": "graphcal::W004",
     "labels": [
       {
         "length": 10,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_missing_host_fn.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P003",
+    "code": "graphcal::W003",
     "labels": [
       {
         "length": 12,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_struct_generic_return.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P001",
+    "code": "graphcal::W001",
     "labels": [
       {
         "length": 4,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_struct_union_return.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P001",
+    "code": "graphcal::W001",
     "labels": [
       {
         "length": 7,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_unknown_fn.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P002",
+    "code": "graphcal::W002",
     "labels": [
       {
         "length": 13,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__extern_use_before_binding.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::P001",
+    "code": "graphcal::W001",
     "labels": [
       {
         "length": 27,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__inline_dag_call_cross_file_unknown_dag__src__lib__main.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::M033",
+    "code": "graphcal::M036",
     "labels": [
       {
         "length": 16,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__inline_dag_call_errors__unknown_dag.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::M033",
+    "code": "graphcal::M036",
     "labels": [
       {
         "length": 10,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__multi__auto_assert_module__src__lib__main.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::M033",
+    "code": "graphcal::M036",
     "labels": [
       {
         "length": 13,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__multi__bad_name_import__src__bad_name_import__main.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::M033",
+    "code": "graphcal::M036",
     "labels": [
       {
         "length": 185,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__multi__module_import_graph_ref__src__params__main.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::M033",
+    "code": "graphcal::M036",
     "labels": [
       {
         "length": 14,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__multi__module_import_mixed__src__lib__main.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::M033",
+    "code": "graphcal::M036",
     "labels": [
       {
         "length": 12,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__prelude_dimension_as_value.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::M033",
+    "code": "graphcal::M036",
     "labels": [
       {
         "length": 6,

crates/graphcal-cli/tests/output_golden/tests__fixtures__invalid__unknown_const_ref.json

@@ -1,6 +1,6 @@
 {
   "check": {
-    "code": "graphcal::M033",
+    "code": "graphcal::M036",
     "labels": [
       {
         "length": 7,

crates/graphcal-compiler/src/semantic_error/module.rs

@@ -144,7 +144,7 @@ impl DiagnosticKind for ModuleError {
             Self::IndexBindingNotAnIndex { .. } => "graphcal::M019",
             Self::IndexKindMismatch { .. } => "graphcal::M018",
             Self::ImportRuntimeItem { .. } => "graphcal::M020",
-            Self::ModuleResolution { .. } => "graphcal::M033",
+            Self::ModuleResolution { .. } => "graphcal::M036",
             Self::AmbiguousModulePath { .. } => "graphcal::M034",
         }
     }

crates/graphcal-compiler/src/semantic_error/plugin.rs

@@ -180,16 +180,16 @@ pub enum PluginLoadFailure {
 impl DiagnosticKind for PluginError {
     fn code(&self) -> &'static str {
         match self {
-            Self::UnknownExternFunction { .. } => "graphcal::P002",
-            Self::InvalidExternSignature { .. } => "graphcal::P001",
-            Self::DuplicateExternParameter { .. } => "graphcal::P011",
-            Self::MissingHostFunction { .. } => "graphcal::P003",
-            Self::ExternCallNotAllowed { .. } => "graphcal::P004",
-            Self::ExternSignatureMismatch { .. } => "graphcal::P005",
-            Self::PluginLoadFailed { .. } => "graphcal::P006",
-            Self::PluginForbiddenImport { .. } => "graphcal::P007",
-            Self::PluginNotPinned { .. } => "graphcal::P009",
-            Self::PluginHashMismatch { .. } => "graphcal::P010",
+            Self::UnknownExternFunction { .. } => "graphcal::W002",
+            Self::InvalidExternSignature { .. } => "graphcal::W001",
+            Self::DuplicateExternParameter { .. } => "graphcal::W011",
+            Self::MissingHostFunction { .. } => "graphcal::W003",
+            Self::ExternCallNotAllowed { .. } => "graphcal::W004",
+            Self::ExternSignatureMismatch { .. } => "graphcal::W005",
+            Self::PluginLoadFailed { .. } => "graphcal::W006",
+            Self::PluginForbiddenImport { .. } => "graphcal::W007",
+            Self::PluginNotPinned { .. } => "graphcal::W009",
+            Self::PluginHashMismatch { .. } => "graphcal::W010",
         }
     }
 

crates/graphcal-compiler/src/semantic_error/tests.rs

@@ -58,7 +58,9 @@ fn every_family_contributes_codes_with_its_own_prefix() {
 }
 
 #[test]
-fn diagnostic_codes_are_unique_and_reassignments_are_pinned() {
+fn diagnostic_code_reassignments_are_pinned() {
+    // Workspace-wide uniqueness is checked by
+    // `crates/graphcal-project/tests/diagnostic_codes.rs`.
     let mut catalog = family_code_catalog();
     let internal = crate::internal_error::InternalError::CODE;
     catalog.insert(
@@ -67,13 +69,6 @@ fn diagnostic_codes_are_unique_and_reassignments_are_pinned() {
     );
     assert!(catalog.len() > 100, "incomplete catalog: {catalog:?}");
 
-    let mut variants_by_code = BTreeMap::new();
-    for (variant, code) in &catalog {
-        if let Some(previous) = variants_by_code.insert(code, variant) {
-            panic!("diagnostic code `{code}` is shared by `{previous}` and `{variant}`");
-        }
-    }
-
     for (variant, expected) in [
         ("LinearAlgebraShapeMismatch", "D022"),
         ("AggregationCardinalityUnknown", "D027"),
@@ -83,6 +78,9 @@ fn diagnostic_codes_are_unique_and_reassignments_are_pinned() {
         ("InvalidEpochTimeScaleArgument", "D029"),
         ("UnsupportedEpochTimeScale", "D030"),
         ("ImportRuntimeItem", "M020"),
+        ("ModuleResolution", "M036"),
+        ("InvalidExternSignature", "W001"),
+        ("PluginHashMismatch", "W010"),
         ("InternalError", "X001"),
     ] {
         assert_eq!(catalog.get(variant).map(String::as_str), Some(expected));
@@ -217,7 +215,7 @@ fn module_resolution_keeps_ambiguous_paths_apart_and_cycles_name_their_templates
     let unknown = ModuleError::resolution(ModuleResolveError::UnknownModule {
         owner: second.clone(),
     });
-    assert_eq!(unknown.code(), "graphcal::M033");
+    assert_eq!(unknown.code(), "graphcal::M036");
     assert_eq!(
         unknown.to_string(),
         ModuleResolveError::UnknownModule {

crates/graphcal-lsp/src/diagnostics.rs

@@ -1069,7 +1069,7 @@ param event: Datetime<TT>(
         assert_eq!(diagnostics.len(), 1, "{diagnostics:?}");
         assert!(matches!(
             &diagnostics[0].code,
-            Some(NumberOrString::String(code)) if code == "graphcal::P011"
+            Some(NumberOrString::String(code)) if code == "graphcal::W011"
         ));
         assert!(diagnostics[0].related_information.is_some());
     }

crates/graphcal-plugin-host/tests/project_eval.rs

@@ -1046,7 +1046,7 @@ node bad: Bool[Item] = scalars::invert(@numbers);
 #[test]
 fn declared_array_signature_must_match_the_manifest() {
     // The declaration says the result reuses the input's index variable but
-    // over a *different* element dimension — structural mismatch, P005.
+    // over a *different* element dimension — structural mismatch, W005.
     let dir = tempfile::tempdir().unwrap();
     let source = r#"
 import plugin "plugins/arrays.wasm" as arrays {

crates/graphcal-plugin/tests/prelude_drift.rs

@@ -5,7 +5,7 @@
 //! verified against the real thing: for every vocabulary name, a `.gcl`
 //! extern declaration spelling that name is compiled against the
 //! macro-produced manifest signature. The loader's structural verification
-//! (P005) then proves both sides denote the same dimension — if the
+//! (W005) then proves both sides denote the same dimension — if the
 //! macro's table ever disagrees with the prelude, these tests fail.
 
 #![cfg(test)]
@@ -153,15 +153,15 @@ fn every_vocabulary_name_matches_the_prelude() {
     let dir = tempfile::tempdir().expect("tempdir");
     let registry = registry_from_embedded_manifest();
     // Structural verification of every declaration against the macro's
-    // manifest happens during compilation; any table drift is a P005.
+    // manifest happens during compilation; any table drift is a W005.
     compile(dir.path(), GCL_DECLARATIONS, &registry)
         .expect("macro vocabulary must match the prelude");
 }
 
 #[test]
 fn drift_would_be_detected() {
     // Negative control: declare one function with the wrong signature and
-    // require P005, proving the positive test actually verifies signatures.
+    // require W005, proving the positive test actually verifies signatures.
     let dir = tempfile::tempdir().expect("tempdir");
     let registry = registry_from_embedded_manifest();
     let source = r#"

crates/graphcal-project/src/project_compiler/pipeline.rs

@@ -329,9 +329,9 @@ pub(super) fn check_hir_project<Mode>(
 ///    the plugin file must have been read by the loader, and the plugin
 ///    host must have registered the module (its recorded failure is
 ///    reported otherwise).
-/// 2. The registry must provide the function (`MissingHostFunction`, P003).
+/// 2. The registry must provide the function (`MissingHostFunction`, W003).
 /// 3. When the registry entry carries a manifest-provided signature, the
-///    declared signature must be structurally equivalent to it (P005) —
+///    declared signature must be structurally equivalent to it (W005) —
 ///    this is the "declaration verified against the embedded manifest"
 ///    guarantee of the plugin design (#25).
 fn verify_host_functions(