Skip to content

view: duplicated Wasm in the site, extra LSP notifications and copied doc strings #2088

Open

Description

@shunichironomura

Warning

This content was written by an AI agent and must be verified by a human developer. After human verification, this alert may be removed.

Found in the review of #2057, which adds the experimental view. Paths refer to #2059's head.

Summary

  • Wasm shipped twice. The site carries the 5.9 MB engine both as site/playground/pkg and as site/view/pkg (just copies the playground's build for the view).
  • Notifications for unseen documents. A client that opts in to graphcal/viewModelDidChange gets one after every analysis of every document, including documents no view shows.
  • Copied doc strings. Each IR stage and each instance copies a declaration's doc string; Arc<str> would share it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    LSPperformancewebviewThe experimental view (web/view, graphcal view, graphcal/viewModel)

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions