Skip to content

view: the ref menu fails without pull request access, and the explorer keeps old refs #2073

Closed

Description

@shunichironomura

Warning

This content was written by an AI agent and must be verified by a human developer. After human verification, this alert may be removed.

Found in the review of #2057, which adds the experimental view. It does not block that PR; #2059 fixed the findings that did. Paths refer to #2059's head.

Problem

  • The ref menu fails as a whole without access to pull requests. web/view/src/github.ts fetches branches, tags and pull requests with Promise.all. Listing pull requests needs the "Pull requests: read" permission, but the sign-in dialog asks only for "Contents: Read-only". For a private repository, the pull request request fails and takes branches and tags with it.
  • The explorer keeps the first repository's refs. web/view/src/explorer.ts caches the refs with this.refs ??= and never resets them or its title when the page moves to another repository.

Proposed fix

  • Use Promise.allSettled, show what loaded, and name the needed permissions in the dialog.
  • Key the explorer's ref cache by owner, repository and token, or reset it on host.onState.

Activity

  1. added
    bugSomething isn't working
    webviewThe experimental view (web/view, graphcal view, graphcal/viewModel)
    on Oct 14, 2026
  2. added a commit that references this issue on Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingwebviewThe experimental view (web/view, graphcal view, graphcal/viewModel)

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions