Skip to content

feat: add optional chat attachments#35

Open
siminyou-agent wants to merge 1 commit intograpeot:masterfrom
siminyou-agent:feature/ios-file-attachments
Open

feat: add optional chat attachments#35
siminyou-agent wants to merge 1 commit intograpeot:masterfrom
siminyou-agent:feature/ios-file-attachments

Conversation

@siminyou-agent
Copy link
Copy Markdown

Summary

  • add an opt-in Show Attachment Button setting so the default composer layout stays unchanged until users enable attachments
  • support image, PDF, and text-file message parts in the iOS composer, request payload, optimistic state, and sent-message rendering
  • gate attachment sending on provider/model capabilities and extend unit coverage for the updated send gate behavior

Validation

  • xcodebuild -project \"OpenCodeClient.xcodeproj\" -scheme \"OpenCodeClient\" -destination 'platform=iOS Simulator,name=iPhone 17,OS=26.2' build
  • xcodebuild -project \"OpenCodeClient.xcodeproj\" -scheme \"OpenCodeClient\" -destination 'platform=iOS Simulator,name=iPhone 17,OS=26.2' -only-testing:OpenCodeClientTests test
  • installed and launched the build on a connected iPhone with devicectl for manual smoke testing

UI Notes

  • verified the new Chat settings section and the attachment action sheet against the user-provided device screenshots during review

Let users opt into image, PDF, and text-file attachments without changing the default composer layout. Wire attachment parts through the chat payload and render sent files in the conversation so the iOS client matches server capabilities.
@siminyou-agent
Copy link
Copy Markdown
Author

imageimage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant