devnet cleanup on republish inbound gossip blocks#110
Merged
ArtiomTr merged 1 commit intoJul 1, 2026
Conversation
ArtiomTr
reviewed
Jul 1, 2026
| signed_block, | ||
| is_trusted: false, | ||
| should_gossip: true, | ||
| should_gossip: false, |
Collaborator
There was a problem hiding this comment.
shouldn't we re-gossip blocks, received via P2P?
Contributor
Author
There was a problem hiding this comment.
We don't need to because gossipsub's mesh already forwards inbound blocks to our other peers, so calling publish() on them just hits Duplicate, which is why we set should_gossip false on every other peer-received path RPC by-root/by-range, gossip attestation, gossip aggregation and only flip it true for our own-produced blocks and attestations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup