attempting to add "fprob" option - #1
Open
jeffcrouse wants to merge 1 commit into
Open
jeffcrouse wants to merge 1 commit into
jeffcrouse wants to merge 1 commit into
Conversation
Owner
|
Hi jefftimesten, thanks for opening a pull request. I think this might need a little work, but since this is kind of an aging project that I haven't worked on in a while, I'll make you a contributor so you can merge this in yourself when you think it's ready. I'd suggest making it a little clearer what this option does, and make sure to fix the typo in the README. Thanks! 🎊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would you say that this is an okay way to do this? I think it might throw the audio out of sync because the skip counter doesn't work properly any more, but I don't know PERL well enough to say.