Repository navigation
build(image): upgrade bundled tools and isolate chart test inputs - #797
Merged
Merged
Conversation
Signed-off-by: thxCode <thxcode0824@gmail.com>
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 5 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
/area worker
/area testing
What this PR does / why we need it:
Upgrades the six bundled CLI tools in
pack/gpustack-operator/Dockerfile, updates the default Instance SSH server image to the published Go 1.27.3 image, and isolatesmake test chart's kubeconfig input:pack/gpustack-operator/Dockerfile,hack/lib/helm.sh):skopeo1.22.0->1.24.1(cloned from canonicalhttps://github.com/podman-container-tools/skopeo)helm3.21.0->3.21.4(aligned acrosspack/gpustack-operator/Dockerfile,hack/lib/helm.sh, and.agents/skills/gpustack-operator-chart-subcharts-manage/SKILL.md)vals0.44.0->0.50.0kustomize5.8.1->5.8.3ytt0.54.0->0.55.4kubectl1.35.3->1.36.5pkg/worker/settings/value.go,docs/reference/settings.md):InstanceImageSSHServerdefault fromgpustack/ssh-server:v1.3.0togpustack/ssh-server:v1.4.0(sha256:23706a2498b07cf6b1e7f296ae28fe11a38e753832b0d178fdfab39a6ab39b1f, built with Go 1.27.3 / Alpine 3.24.3 in build(ssh-server): use go 1.27.3 and alpine 3.24.3 #787 / test(ssh-server): wait for smoke prerequisites #790).hack/lib/helm.sh,hack/check/helm-chart-test-selftest.sh):gpustack::helm::testresolves a non-empty single-fileKUBECONFIG(or falls back to${HOME}/.kube/config), rejects path lists, missing paths, and non-regular files before invoking Docker, resolves relative paths to absolute host paths, and bind-mounts the file read-only (:ro) without mutating the caller's configuration.hack/check/toolpins-selftest.sh,hack/check/helm-chart-test-selftest.sh,hack/lint.sh,hack/check/hook-dispatch.sh):InstanceImageSSHServerdocumentation default, plus fixture/mutation tests forgpustack::helm::test::kubeconfig.Which issue(s) this PR links to:
Relates #787
Relates #790
Relates #794
Special notes for your reviewer:
linux/arm64andlinux/amd64operator image builds and all 15 tool/invocation contracts inside the built images,bash hack/check/toolpins-selftest.sh .,bash hack/check/helm-chart-test-selftest.sh .,make lint,make lint docs, andmake test chartagainst an isolated kubeconfig on Kubernetes v1.36.1.Does this PR introduce a user-facing change?