Repository navigation
Conversation
Every case header gains a Prerequisites line between the title block and Goal, naming in one machine-readable line what the case minimally needs: node count, accelerator vendors, hardware features, cluster kind and gating environment variables. A new read-only _env-audit.sh reads those lines against a live cluster and prints one RUN/SKIP/UNKNOWN row per case, so a coding agent can decide what to run before spending a single fixture. The builder-env variables in SKILL.md now say who consumes them (build-load.sh, not the cases). Reviewed by qwen (GLM-5.3-Flash): one major (case-52 overstated features=rdma when its negative assertion is the point on RDMA-less nodes) and five minors (missing env-var inputs on cases 28 and 39, an EFA probe that could never fire, a partition probe missing the coarse family key, and a store probe answering SKIP where its own contract says UNKNOWN) - all fixed here. Signed-off-by: thxCode <thxcode0824@gmail.com>
|
✅ OpenCodeReview: Review skipped: no items were selected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
/kind cleanup
/area testing
What this PR does / why we need it:
Every case in the e2e suite now carries a machine-readable
Prerequisites:line between its title block and Goal, naming in one line what it minimally needs: node count, accelerator vendors, hardware features, cluster kind and gating environment variables. A new read-onlycases/_env-audit.shreads those lines against a live cluster and prints one RUN/SKIP/UNKNOWN row per case, so a coding agent can decide what to run before spending a single fixture.The builder-env variables in SKILL.md now say who consumes them (
build-load.sh, not the cases) and what each one controls.Implemented by MiniMax Code, reviewed by Qwen (GLM-5.3-Flash). The review found six issues (one major: a case overstated
features=rdmawhen its negative assertion is the point on RDMA-less nodes; five minor: missing env-var inputs, an EFA probe matching the wrong key, a partition probe missing the coarse family key, and a store probe answering SKIP where its own contract says UNKNOWN) — all fixed here.Which issue(s) this PR links to:
Relates #786