Repository navigation
build(llm-router): bump llm-d-router to v0.11.0 and patch vllm-router for EPD - #761
Merged
Merged
Conversation
- rebase the observer patch onto v0.11.0 and keep its seven revision sites - allow the passthrough parser that v0.11.0 adds to the default set - add a lock-order test that fails on the observer and datastore lock inversion Signed-off-by: thxCode <thxcode0824@gmail.com>
Pin vllm-router at v0.1.16.1 and carry the upstream EPD routing change (commit 516f1cb) as a patch, because no release tag contains it yet. The patch header and Dockerfile state that the pin moves to the first upstream tag carrying 516f1cb and deletes 0001-epd-routing.patch. Rebase the Mooncake lookup and observer patches onto the new base without changing their content. Restore the discovery readiness patch as the fourth patch. It now compares Pod values without the UID and its tests use a stub router, so the upstream test suite passes with it. The patched tree passes the same tests as the clean tag. The only failures on both are the eight wasm_middleware tests, which need a wasm32-wasip2 target. Signed-off-by: thxCode <thxcode0824@gmail.com>
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
/area worker
What this PR does / why we need it:
LLMD_ROUTER_VERSIONinpack/llm-router/Dockerfilefromv0.10.0tov0.11.0and rebasespack/llm-router/patches/llm-d/0001-observer-endpoints-and-dispatch.patchontov0.11.0:passthroughparser added to the default set inv0.11.0.vllm-project/routerPR 266 (commit516f1cb, Encoder-Prefill-Decode routing) aspack/llm-router/patches/vllm-router/0001-epd-routing.patchonVLLM_ROUTER_VERSION=v0.1.16.1, because no upstream release tag contains516f1cbyet:pack/llm-router/Dockerfileand the patch header thatVLLM_ROUTER_VERSIONmoves to the first upstream tag containing516f1cband drops0001-epd-routing.patch.0002) and read-only observer endpoint (0003) patches onto the patched tree.0004) with UID-excluded Pod comparison and stub-router unit tests so the upstream test suite passes.Which issue(s) this PR links to:
NONE
Special notes for your reviewer:
Base Imageworkflow can publish a newgpustack/llm-routerimage before the operator's default router image setting is bumped.git apply --checkandgit applyon their pinned upstream refs (llm-d/llm-d-routerv0.11.0andvllm-project/routerv0.1.16.1), and that the patched trees compile and pass their unit tests (go test ./...forllm-d-routerandcargo test --locked --bin vllm-router --libforvllm-router).Does this PR introduce a user-facing change?