Repository navigation
test(e2e): fix four failing Nebius cases (87, 99, 104, 107) - #758
Merged
Merged
Conversation
Case 87 aborted with no row on a cluster whose Nodes carry no zone label. It now prints one SKIP row naming the measured shape and exits 0. Case 99 wrote the Hugging Face token into its Secret through a here-string, which appends a newline, so the gated download sent a malformed Authorization header. It now pipes the token with printf '%s'. Cases 101 and 104 read plugin metrics through the API server pod proxy. The model-manager NetworkPolicy admits only the plugins, the worker and the configured scrapers on the secure port, so the proxy timed out on a CNI that enforces it. A new plugin_metrics helper reads them from inside the plugin container over the loopback, which the policy never filters. Case 107 mixed Nodes of two CPU models, so Kueue split them across two ResourceFlavors. It picks a flavor first and TAS ranks Nodes only inside it, so a preferred term naming a Node of the other flavor could not win. The case now keeps the largest same-model group and exits 2 when none has two Nodes. Test scripts and the e2e skill table only. No product code or chart change. Not yet run on a cluster. Signed-off-by: thxCode <thxcode0824@gmail.com>
|
✅ OpenCodeReview: Review skipped: no items were selected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
/area testing
What this PR does / why we need it:
Four e2e cases failed on the Nebius run of role mutability for reasons that sit in the test scripts, not in the product. Each root cause below was checked against the run logs or the code.
jq: Cannot iterate over nullon a cluster whose Nodes carry no zone label. It now prints one SKIP row that names the measured shape, then exits 0.Authorizationheader. It now pipes the token withprintf '%s', as case 101 already does.:32444/proxy/metrics). The model-manager NetworkPolicy admits only the plugins, the worker and the configured scrapers on that port, so the proxy timed out. A newplugin_metricshelper reads them from inside the plugin container over the loopback, which the policy never filters.TASRespectNodeAffinityPreferredgate was loaded (loaded=true), so it is not the cause.Which issue(s) this PR links to:
NONE
Special notes for your reviewer:
make lint agents-shell,make lint docs,git diff --check, and a local simulation of the case 107 grouping with four pool shapes. The simulation caught one bug in my first version (the CPU id had no trailing newline, sosort -umerged all Nodes); it is fixed.maincontainer hascurl(the image installs it, and case 111 already relies on it), and Kueue gives the same-flavor pool the 1/K baseline that case 107 tests against.Does this PR introduce a user-facing change?