Repository navigation
fix(chart): unify global.hub registry overrides - #747
Merged
Merged
Conversation
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area worker
What this PR does / why we need it:
When an umbrella chart sets only
global.hub, Kueue and Topograph still use their original registries. The worker also receives no runtime registry override.Use
global.imageRegistryfirst, thenglobal.hub, in every bundled image helper and the worker environment. Normalize trailing slashes before exporting the runtime registry. Keep all five vendoring patches consistent with the committed helpers.Which issue(s) this PR links to:
NONE
Special notes for your reviewer:
make testpassed: 99 packages with race, shuffle, and coverage.make lintandmake lint chartpassed.GPUSTACK_CONTAINER_REGISTRY.Does this PR introduce a user-facing change?