Skip to content

fix(chart): unify global.hub registry overrides - #747

Merged
thxCode merged 1 commit into
mainfrom
fix-kueue-hub-alias
Oct 8, 2026
Merged

thxCode merged 1 commit into
mainfrom
fix-kueue-hub-alias

Conversation

@thxCode

@thxCode thxCode commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind bug
/area worker

What this PR does / why we need it:

When an umbrella chart sets only global.hub, Kueue and Topograph still use their original registries. The worker also receives no runtime registry override.

Use global.imageRegistry first, then global.hub, in every bundled image helper and the worker environment. Normalize trailing slashes before exporting the runtime registry. Keep all five vendoring patches consistent with the committed helpers.

Which issue(s) this PR links to:

NONE

Special notes for your reviewer:

  • make test passed: 99 packages with race, shuffle, and coverage.
  • make lint and make lint chart passed.
  • Render checks enable optional chart components and cover the alias, trailing slashes, explicit registry precedence, and GPUSTACK_CONTAINER_REGISTRY.
  • The checks rejected missing Kueue alias support and unnormalized runtime values before their fixes.
  • All five image patches applied during forced restaging. The three existing alias helpers are preserved by their patch sources.
  • Independent source review found the runtime trailing-slash case. Its fix and regression checks are included.
  • Cluster E2E was not run. Validation covers unit tests, patch application, and local Helm renders.

Does this PR introduce a user-facing change?

global.hub controls all bundled chart images and the worker's runtime registry. global.imageRegistry takes precedence when both are set. Trailing registry slashes are normalized before runtime images are built.

@gpustack-code-review

Copy link
Copy Markdown

✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s).

@thxCode
thxCode merged commit 3ce2edd into main Oct 8, 2026
17 checks passed
@thxCode
thxCode deleted the fix-kueue-hub-alias branch October 8, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant