Repository navigation
github-board: draw the GitHub logo as inline SVG, check icon names in CI, and release 0.11.0 - #112
Merged
Merged
Conversation
… CI, and release 0.11.0 Paseo's icon set is lucide-react-native 1.50.0, which has no brand icons, so "Github" never resolved; Paseo 0.15.2 rejects it when the settings screen registers and the plugin fails to load (#111). The settings screen, both Command Center items, the sidebar row and the timeline card now use GITHUB_MARK, Primer Octicons' mark-github-16 as `{ svg }` with fill="currentColor". The `{ svg }` form and `<Icon icon>` arrived in Paseo 0.13.0, so the SDK pins move to 0.13.0 and requirements.paseo to >=0.13.0. A test runs the mark through the SDK's findSvgIconProblem. .github/scripts/check-lucide-icons.mjs, run as the "Icons exist" job, reads every icon name in each plugin's client code and fails on one that lucide-react-native 1.50.0 does not export. The sweep found no other unknown name in any plugin. Closes #111 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111
The problem
github-board 0.10.2 fails to load on Paseo 0.15.2 with
Settings screen board has an invalid icon: unknown Lucide icon "Github". Paseo resolves a string icon withReflect.getover its ownlucide-react-native, which has been 1.50.0 from Paseo 0.11.0 through 0.15.3. That version has no brand icons, so"Github"was never a name it could resolve.The fix
client/github-mark.tsexportsGITHUB_MARK: Primer Octicons'mark-github-16(MIT) as{ svg }withfill="currentColor". The viewBox is padded so the mark matches the size of the Lucide icons next to it. All fourGithubuses switch to it. The timeline card uses the mark through<Icon icon>. The issue suggestedGitPullRequestthere, but a card can also be an issue or a discussion.Floor raise: the
{ svg }icon form and<Icon icon>first appear in Paseo /@getpaseo/plugin0.13.0. So github-board re-pins@getpaseo/plugin,clientandprotocolto exactly0.13.0, andrequirements.paseorises to>=0.13.0. That is why this is a minor bump to 0.11.0. The changelog tells users on Paseo 0.11 or 0.12 to stay on 0.10.2.client/github-mark.test.tsruns the mark through the SDK's ownfindSvgIconProblem, the same check the host applies when the icon registers.Every icon changed, per plugin
index.client.tsx, settings screenboard:"Github"→GITHUB_MARKindex.client.tsx, Command Center itemopen-board:"Github"→GITHUB_MARKclient/sidebar-item.tsx,SidebarRow:"Github"→GITHUB_MARKclient/timeline.tsx,<Icon name="Github">→<Icon icon={GITHUB_MARK}>Regression check
.github/scripts/check-lucide-icons.mjsruns as a new Icons exist job, whichChecks passednow needs. Itnpm packslucide-react-native@1.50.0and reads the export names (icons plus aliases) from its type declarations. It then checks every PascalCase string literal in each plugin's client code that sits in an icon slot:icon:,icon=andname=values, including both arms of a ternary*_ICONconstants*_ICONSmapsIt does not need
npm ci. Run againstmain's github-board, it reports all fourGithubuses. On this branch every plugin passes (179 icon names in total).Root
AGENTS.mdloses the wrong "brand icons are in there too —Github" line. It now says Paseo's Lucide set has no brand icons, a logo has to be{ svg }(Paseo 0.13+), and what the new check reads. It also records github-board's 0.13 floor and pin.github-board/AGENTS.mdandREADME.mdare updated to match.Verification
npm run typecheckandnpm testpass in all six plugins: skills 112, github-board 122, launchd-jobs 67, herald 125, model-pricing 102, firstmate 280.check-plugin-consistency.mjs,check-changelog-bump.mjsandcheck-lucide-icons.mjsall pass locally.npm pack --dry-runshipsclient/github-mark.tsand leaves out the test.Follow-ups (not icon-related, not fixed here)
@getpaseo/plugin/client/react-nativeis deprecated in favour of@getpaseo/plugin/client/ui. The SDK says it will be removed after 2027-04-20. It is imported in 33 files: firstmate 16, herald 6, skills 4, github-board 3, launchd-jobs 2, model-pricing 2.🤖 Generated with Claude Code