Skip to content

github-board: draw the GitHub logo as inline SVG, check icon names in CI, and release 0.11.0 - #112

Merged
gpambrozio merged 1 commit into
mainfrom
fm/paseo-plugins-lucide-brand-icons
Nov 7, 2026
Merged

gpambrozio merged 1 commit into
mainfrom
fm/paseo-plugins-lucide-brand-icons

Conversation

@gpambrozio

Copy link
Copy Markdown
Owner

Closes #111

The problem

github-board 0.10.2 fails to load on Paseo 0.15.2 with Settings screen board has an invalid icon: unknown Lucide icon "Github". Paseo resolves a string icon with Reflect.get over its own lucide-react-native, which has been 1.50.0 from Paseo 0.11.0 through 0.15.3. That version has no brand icons, so "Github" was never a name it could resolve.

The fix

client/github-mark.ts exports GITHUB_MARK: Primer Octicons' mark-github-16 (MIT) as { svg } with fill="currentColor". The viewBox is padded so the mark matches the size of the Lucide icons next to it. All four Github uses switch to it. The timeline card uses the mark through <Icon icon>. The issue suggested GitPullRequest there, but a card can also be an issue or a discussion.

Floor raise: the { svg } icon form and <Icon icon> first appear in Paseo / @getpaseo/plugin 0.13.0. So github-board re-pins @getpaseo/plugin, client and protocol to exactly 0.13.0, and requirements.paseo rises to >=0.13.0. That is why this is a minor bump to 0.11.0. The changelog tells users on Paseo 0.11 or 0.12 to stay on 0.10.2.

client/github-mark.test.ts runs the mark through the SDK's own findSvgIconProblem, the same check the host applies when the icon registers.

Every icon changed, per plugin

  • github-board (0.10.2 → 0.11.0)
    • index.client.tsx, settings screen board: "Github" → GITHUB_MARK
    • index.client.tsx, Command Center item open-board: "Github" → GITHUB_MARK
    • client/sidebar-item.tsx, SidebarRow: "Github" → GITHUB_MARK
    • client/timeline.tsx, <Icon name="Github"> → <Icon icon={GITHUB_MARK}>
  • skills, launchd-jobs, herald, model-pricing, firstmate: no changes. Every icon name they use exists in lucide-react-native 1.50.0, so none of them is bumped.

Regression check

.github/scripts/check-lucide-icons.mjs runs as a new Icons exist job, which Checks passed now needs. It npm packs lucide-react-native@1.50.0 and reads the export names (icons plus aliases) from its type declarations. It then checks every PascalCase string literal in each plugin's client code that sits in an icon slot:

  • icon:, icon= and name= values, including both arms of a ternary
  • *_ICON constants
  • the values of *_ICONS maps

It does not need npm ci. Run against main's github-board, it reports all four Github uses. On this branch every plugin passes (179 icon names in total).

Root AGENTS.md loses the wrong "brand icons are in there too — Github" line. It now says Paseo's Lucide set has no brand icons, a logo has to be { svg } (Paseo 0.13+), and what the new check reads. It also records github-board's 0.13 floor and pin. github-board/AGENTS.md and README.md are updated to match.

Verification

  • npm run typecheck and npm test pass in all six plugins: skills 112, github-board 122, launchd-jobs 67, herald 125, model-pricing 102, firstmate 280.
  • check-plugin-consistency.mjs, check-changelog-bump.mjs and check-lucide-icons.mjs all pass locally.
  • npm pack --dry-run ships client/github-mark.ts and leaves out the test.
  • The mark was rendered locally and looks right. Not done: the board has not been looked at in a running Paseo app (no plugin UI harness, and the captain's Paseo was off limits). A look at the sidebar row, the Command Center, Settings and a timeline card in both themes is still owed before merging, since merging releases.

Follow-ups (not icon-related, not fixed here)

  • @getpaseo/plugin/client/react-native is deprecated in favour of @getpaseo/plugin/client/ui. The SDK says it will be removed after 2027-04-20. It is imported in 33 files: firstmate 16, herald 6, skills 4, github-board 3, launchd-jobs 2, model-pricing 2.
  • Every plugin other than github-board is still pinned to an SDK older than 0.15. This PR does not check them against 0.15.2 for anything except icon names.

🤖 Generated with Claude Code

… CI, and release 0.11.0

Paseo's icon set is lucide-react-native 1.50.0, which has no brand icons, so "Github" never
resolved; Paseo 0.15.2 rejects it when the settings screen registers and the plugin fails to
load (#111). The settings screen, both Command Center items, the sidebar row and the timeline
card now use GITHUB_MARK, Primer Octicons' mark-github-16 as `{ svg }` with fill="currentColor".

The `{ svg }` form and `<Icon icon>` arrived in Paseo 0.13.0, so the SDK pins move to 0.13.0 and
requirements.paseo to >=0.13.0. A test runs the mark through the SDK's findSvgIconProblem.

.github/scripts/check-lucide-icons.mjs, run as the "Icons exist" job, reads every icon name in
each plugin's client code and fails on one that lucide-react-native 1.50.0 does not export. The
sweep found no other unknown name in any plugin.

Closes #111

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gpambrozio
gpambrozio merged commit 187ad1b into main Nov 7, 2026
10 checks passed
@gpambrozio
gpambrozio deleted the fm/paseo-plugins-lucide-brand-icons branch November 7, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github-board 0.10.2 fails to load: unknown Lucide icon "Github"

1 participant