wip: Use SES to send all confirmation emails#2164
Draft
alice-carr wants to merge 1 commit into
Draft
Conversation
alice-carr
force-pushed
the
use-ses-to-send-all-confirmation-emails
branch
2 times, most recently
from
ab29a85 to
aa74833
Compare
alice-carr
force-pushed
the
use-ses-to-send-all-confirmation-emails
branch
5 times, most recently
from
3748e0d to
b403299
Compare
we currently use SES to send confirmation emails that include a copy of the user's answers, and notify to send the confirmation emails that don't. This commit changes this so that all confirmation emails are sent with SES. it also updates the tests to support this.
alice-carr
force-pushed
the
use-ses-to-send-all-confirmation-emails
branch
from
b403299 to
10f3022
Compare
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2164.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/GfBTJbNL/3154-blocked-until-a-sprint-after-copy-of-answers-launch-use-ses-to-send-all-confirmation-emails
We currently use SES to send confirmation emails that include a copy of the user’s answers and Notify to send confirmation emails that do not. We should switch all confirmation emails to use SES.
This can't be merged until work on the e2e tests has been done
Things to consider when reviewing